Re: [Wxlua-users] Bug: Wrong parameters in wxDir:GetAllFiles()

[John L. <jla...@gm...>]

On 7/19/06, Steve Kieu <ha...@ya...> wrote:
>
> I think it's ok. This is one of the overridden functions where the
> function call doesn't take the input wxArrayString, but rather returns
> the array as a lua table.
>
> // %override [unsigned int, lua string table] wxDir::GetAllFiles(const
> wxString& dirname, const wxString& filespec = "", int flags =
> wxDIR_DEFAULT)
>
> My apology, it is just that I read the un commented line
>
> %wxchkver23 static unsigned int GetAllFiles(const wxString& dirname,
> wxArrayString *files, const wxString& filespec = "", int flags =
> wxDIR_DEFAULT)
>
> and still  think that the method is still using *files  its argument so I
> still pass dummy args into it and it failled, then whining about it :-). I
> should look at the override line .

The uncommented line is written exactly as the C++ function is to make
it easy to check that the parameters are the same when the files are
updated to a newer version of wxWidgets. I've tried to document all
the %override functions in the .i files appropriately.

> What do you think? On one hand it's nice to use the native lua table
> for arrays like this, but on the other hand the bindings are easier
> with fewer overrides and confusion with the wxWidgets docs if we keep
> it as a wxArrayString.
> I personally prefer lua table; as I can get it out, process it using lua
> code etc. It is just much easier to use lua then , my memory is not good,
> and lots of time I have to open wx docs to find a method name etc.. but I
> can not forget :
> for i,v in pairs(bla) do    :-)  end

Ok then we'll keep it this way. There are only a few of these so it's
not a big deal to maintain them.

Regards,
    John Labenski