From: John L. <jla...@gm...> - 2006-05-24 05:03:48
|
On 5/23/06, Francesco Montorsi <f18...@ya...> wrote: > >> 2) setting the #define wxLuaDebugServer to 1 in wxluasetup.h generates a > >> dependency of wxbind module to the wxluasocket (and thus also to > >> wxluadebug) module. Is this a good thing to do ? > >> Shouldn't we keep all wxLuaDebugServer stuff in the wxluasocket module? > > > > Yes. This is a throwback to when we had a single monolithic binding. I > > can change this so that the wxLuaSocket stuff will go into > > modules/wxluasocket. This means that there will be another binding dir > > wxluasocket and it will output into the wxluasocket module src dir to > > get compiled along with the current wxluasocket code. > I think this should be done... This has been done. Three new files that are in the wxluasocket module since they are tied to it. modules/include/wxluasocket_bind.h modules/src/wxluasocket.cpp modules/src/wxluasocket_bind.cpp in addition to bindings/wxluasocket. -John Labenski ps. I think you may have inadvertently broken the wxstc bindings when you changed the #include for the wxbindstc lib from wxbind/include/wxbind.h to wxbindstc/include/wxbind.h in the wxstc rules file. The wxbindstc lib requires the wxbind lib and I just include the wxbind include to get at wxluasetup.h. Is this a problem? The bottom line is that the wxluasetup.h has to be included since the wxbindstc lib uses some of the wxLUA_USE_XXX like wxPointSizeRect and if you don't include that you don't get the wxStyledTextCtrl constructor! Running the apps/wxlua app is a very good test to see if things are generally ok which is why I'm so insistent that it's easy to build and all defaults are catered to fully building it at the expense of making it easy to build anything else. |