From: Francesco M. <f18...@ya...> - 2006-03-07 19:09:04
|
John Labenski ha scritto: > On 3/7/06, Francesco Montorsi <f18...@ya...> wrote: >> Anders F Björklund ha scritto: >>> Francesco Montorsi wrote: >>> >>>> I've checked in the __WXMAC__ changes and the inclusion of internal.h >>>> but not these changes: >>>> >>>> +#ifndef __WXMAC__ >>>> // call constructor >>>> returns = new wxDropSource(win, *iconCopy, *iconMove, *iconStop); >>>> +#else >>>> + returns = new wxDropSource(win); >>>> +#endif >>>> >>>> they affect automatically-generated files rather than their generators >>>> and thus should be changed. >>>> Why does Mac need this asimmetry ? >>> Someone declared the Mac constructor with the wrong type arguments... >>> The icons aren't being used anyway, so it's a pretty silly error :-) >>> >>> // ctors: if you use default ctor you must call SetData() later! >>> // >>> // NB: the "wxWindow *win" parameter is unused and is here only for >>> wxGTK >>> // compatibility, as well as both icon parameters >>> wxDropSource( wxWindow *win = (wxWindow *)NULL, >>> const wxCursor &cursorCopy = wxNullCursor, >>> const wxCursor &cursorMove = wxNullCursor, >>> const wxCursor &cursorStop = wxNullCursor); >>> >>> I thought it would be easiest to just *not* supply the icons on wxMac ? >>> (BTW; You can peek at the Mac stuff for wxWidgets, it's in "mac/carbon") >> This really looks as a bug in wxWidgets itself. >> I think it would be difficult to handle this case nicely in wxLua >> binding wrappers... it's probably better to submit a patch to wx devs >> and ask them to apply it before 2.6.3... >> if those icons aren't really used it should not be a big issue just >> replacing wxCursor->wxIcon... > > I did a fix for it in the binding files. Hopefully it'll work now. > > %win|%mac wxDropSource(wxWindow* win = NULL, const wxCursor& > iconCopy = wxNullCursor, const wxCursor& iconMove = wxNullCursor, > const wxCursor& iconStop = wxNullCursor) > > %gtk wxDropSource(wxWindow* win = NULL, const wxIcon& iconCopy = > wxNullIcon, const wxIcon& iconMove = wxNullIcon, const wxIcon& > iconStop = wxNullIcon) very nice workaround but I'll send a mail to wxdev anyway. > > Francesco, are there any other things that need to be fixed that you > haven't done yet? no; now wxLua should compile & work also on wxMac. We just need wxMac screenshots and packaging stuff :) Francesco |