Re: [Wxlua-users] Re: wxLua for wxMac

[John L. <jla...@gm...>]

On 3/7/06, Francesco Montorsi <f18...@ya...> wrote:
> Anders F Bj=F6rklund ha scritto:
> > Francesco Montorsi wrote:
> >
> >> I've checked in the __WXMAC__ changes and the inclusion of internal.h
> >> but not these changes:
> >>
> >> +#ifndef __WXMAC__
> >>      // call constructor
> >>      returns =3D new wxDropSource(win, *iconCopy, *iconMove, *iconStop=
);
> >> +#else
> >> +    returns =3D new wxDropSource(win);
> >> +#endif
> >>
> >> they affect automatically-generated files rather than their generators
> >> and thus should be changed.
> >> Why does Mac need this asimmetry ?
> >
> > Someone declared the Mac constructor with the wrong type arguments...
> > The icons aren't being used anyway, so it's a pretty silly error :-)
> >
> >     // ctors: if you use default ctor you must call SetData() later!
> >     //
> >     // NB: the "wxWindow *win" parameter is unused and is here only for
> > wxGTK
> >     //     compatibility, as well as both icon parameters
> >     wxDropSource( wxWindow *win =3D (wxWindow *)NULL,
> >                  const wxCursor &cursorCopy =3D wxNullCursor,
> >                  const wxCursor &cursorMove =3D wxNullCursor,
> >                  const wxCursor &cursorStop =3D wxNullCursor);
> >
> > I thought it would be easiest to just *not* supply the icons on wxMac ?
> > (BTW; You can peek at the Mac stuff for wxWidgets, it's in "mac/carbon"=
)
> This really looks as a bug in wxWidgets itself.
> I think it would be difficult to handle this case nicely in wxLua
> binding wrappers... it's probably better to submit a patch to wx devs
> and ask them to apply it before 2.6.3...
> if those icons aren't really used it should not be a big issue just
> replacing wxCursor->wxIcon...

I did a fix for it in the binding files. Hopefully it'll work now.

    %win|%mac wxDropSource(wxWindow* win =3D NULL, const wxCursor&
iconCopy =3D wxNullCursor, const wxCursor& iconMove =3D wxNullCursor,
const wxCursor& iconStop =3D wxNullCursor)

    %gtk wxDropSource(wxWindow* win =3D NULL, const wxIcon& iconCopy =3D
wxNullIcon, const wxIcon& iconMove =3D wxNullIcon, const wxIcon&
iconStop =3D wxNullIcon)


Francesco,  are there any other things that need to be fixed that you
haven't done yet?

Regards,
    John Labenski