Re: [Wxlua-users] Re: Why wxluasetup.h.in and wxluasetup.h ?

[John L. <jla...@gm...>]

On 2/3/06, Francesco Montorsi <f18...@ya...> wrote:
> Hi,
>
> John Labenski ha scritto:
> >>> so I thought that it was a 'cleaner' idea to put wxluasetup.h in
> >>>
> >>> modules/wxbind/setup
> >>>
> >>> instead of modules/setup. After all, wxluasetup.h is a setup for
> >>> wxbind, right ?
> >> But that is putting it in a module. While there are already two bindin=
g
> >> modules.
> >> I am not sure it they use the same wxluasetup.h, but if yes i would sa=
y
> >> it has to be in:
> >>
> >> modules/setup
> >>
> >> Currently i see a wxluasetup.h in wxbindstc/src  too.
> >>
> >> or in a new include dir in:
> >>
> >> modules/bindings/include
> >>
> >> I can imagine that this file can be used module broad for more then
> >> setting bindings on/off.
> >
> > That's where it gets a little tricky. The wxSTC binding also depends
> > on the wxLUA_USE stuff, for example wxPoint, wxColour, wxWindow, etc,
> > but I really don't want to have to go nuts and cross link all the
> > dependencies since it'll make things very complicated.
> >
> > I suppose the best solution is to use the wxSTC bindings without any
> > wxluasetup.h file and in a doc file just state the things that have to
> > be turned on to make it work. It should be pretty obvious to people
> > that if they want a complicated widget like wxSTC they have to bind to
> > a large portion of wxWidgets.
> even better, I think that a set of blocks like:
>
> #if !wxLUA_USE_REQUIREDFEATURE
>         #error Cannot build wxSTC bindings with wxLUA_USE_REQUIREDFEATURE=
 =3D 0 !
> #endif
>
> could be very useful...

Could be a pain in the ass to maintain too. :)  Remember that if you
do this then the wxSTC binding has to find the wxluasetup.h file that
was used for the wxWidgets bindings. I don't think that people will
have a hard time understanding that if they want to use wxSTC they've
got to include the classes it depends on.

> PS: BTW on my local copy I see now two wxluasetup.h; one in
> modules/wxbind/setup and one in modules/wxbindstc/src.
> If I understood correctly, the last one can be removed, right ?

Not yet, the bindings have to be rewritten to not use it.

> What about the first one ? John, do you agree with Klaas that it should
> be moved one level up (in modules/setup) ?

Ehhhh, I think it's not a general wxLua setup file, but rather that
it's just for the wxWidgets bindings. I like your idea of putting it
in wxbind/setup. If there are ever any other bindings, they may have
their own setup files. I'd leave it where it is.

-John