Re: [Wxlua-users] wxchkver25

[klaas.holwerda <kho...@xs...>]

Hi John,

If you go to the generated wave.cpp, you will find several   wxchkver25 
which or not commented and or not translated.
So i think there is a bug somehow.

e.g. I see:

#if (defined(__WXMSW__) && !wxchkver25) && (wxLUA_USE_wxWave)

OR

#if (!wxCHECK_VERSION(2,5,0)) && ((defined(__WXMSW__) && !wxchkver25) && 
(wxLUA_USE_wxWave))
//     !%wxchkver25 bool Play(bool async = TRUE, bool looped = FALSE) const

John Labenski wrote:

>I don't know if it's worth it to fix them all if we're
>getting new wrappers anyway since it'll be hard to compare the two and
>you'll have to check everything all over again.
>  
>
I see, just did a few i saw now, not a big deal, i just leaf them in.

>I think it should be this, only include this if the wxWidgets version
>is < 2.5 or if WXWIN_COMPATIBILITY_2_4 is on.
>!%wxchkver25|%wxcompat24 void SetPrinterOptions(const wxString& options)
>  
>
It looks like %wxcompat24 does the job, but i will keep it in mind.

>  
>
>>What about that property?
>>    
>>
>
>Put the same checks for the property since it's basicly the same thing.
>  
>
Oke i did that.

>Some of the checks are really ugly, we should write a parser for 
>%wxchkver(2,5,0) so that it can be translated to
>wxCHECK_VERSION(2,5,0) directly without having to mess with all the
>%wxchverXX translations in wxluawrap.lua. Again, this is a trivial
>thing, but time consuming and a big change like this would make it
>very difficult to merge back in with Rays new wrappers so I was going
>to do it afterwards if people liked it.
>  
>
Oke better wait some more then :-(

Thanks,

Klaas