#37 Fails to build with Lua 5.3

[Ildar Mulyukov]

with failure messages like these:

[ 50%] Building CXX object modules/luamodule/CMakeFiles/wxLuaModule.dir/__/wxlua/wxlstate.cpp.o
/usr/src/RPM/BUILD/wxLua-2.8.12.3-src/modules/wxlua/wxlstate.cpp: In member function 'int wxLuaState::lua_Dump(lua_Writer, void*)':
/usr/src/RPM/BUILD/wxLua-2.8.12.3-src/modules/wxlua/wxlstate.cpp:1875:62: error: too few arguments to function 'int lua_dump(lua_State*, lua_Writer, void*, int)'
     return lua_dump(M_WXLSTATEDATA->m_lua_State, writer, data);
                                                              ^
In file included from /usr/src/RPM/BUILD/wxLua-2.8.12.3-src/modules/wxlua/wxldefs.h:19:0,
                 from /usr/src/RPM/BUILD/wxLua-2.8.12.3-src/modules/wxlua/wxlstate.h:13,
                 from /usr/src/RPM/BUILD/wxLua-2.8.12.3-src/modules/wxlua/wxlstate.cpp:22:
/usr/include/lua.h:283:14: note: declared here
 LUA_API int (lua_dump) (lua_State *L, lua_Writer writer, void *data, int strip);
              ^~~~~~~~
/usr/src/RPM/BUILD/wxLua-2.8.12.3-src/modules/wxlua/wxlstate.cpp: In member function 'int wxLuaState::lua_SetHook(lua_Hook, int, int)':
/usr/src/RPM/BUILD/wxLua-2.8.12.3-src/modules/wxlua/wxlstate.cpp:2036:70: error: void value not ignored as it ought to be
     return lua_sethook(M_WXLSTATEDATA->m_lua_State, func, mask, count);
                                                                      ^

This is critical for modern setups. r252.

[Ildar Mulyukov]

Oh! This is successfully been solved by Paul Kulchenko in https://github.com/pkulchenko/wxlua/tree/wxwidgets311 . His fork seem to be viable BTW.

[Pavel Kulchenko]

Yes, these changes have been merged into master branch of https://github.com/pkulchenko/wxlua/, so the ticket can be closed.