#233 white texts become invisible when wx.WHITE is used as background

[Joe Chan]

wx.WHITE as backgrould will mask the white text when users using dark screen mode. Suggest using wx.Colour(125, 125, 125, 255) instead of wx.WHITE.
Only two py files are affected: new_properties.py and window_dialog.py

[Dietmar Schwertberger]

Hi Joe,
thanks for reporting.
I would prefer not to use grey as background.

Would this work with your colour settings instead?
self.text.SetBackgroundColour(wx.SystemSettings.GetColour(wx.SYS_COLOUR_WINDOW))

or on Classic (with underscore): self.text.SetBackgroundColour(wx.SystemSettings_GetColour(wx.SYS_COLOUR_WINDOW))

Alternatively, I could read the default once like this wx.TextCtrl().GetBackgroundColour()

for n in dir(wx):
    if not n.startswith("SYS_COLOUR"): continue
    print("%-20s"%n[11:], wx.SystemSettings.GetColour(getattr(wx, n)))

3DDKSHADOW           (64, 64, 64, 255)
3DFACE               (212, 208, 200, 255)
3DHIGHLIGHT          (255, 255, 255, 255)
3DHILIGHT            (255, 255, 255, 255)
3DLIGHT              (212, 208, 200, 255)
3DSHADOW             (128, 128, 128, 255)
ACTIVEBORDER         (212, 208, 200, 255)
ACTIVECAPTION        (10, 36, 106, 255)
APPWORKSPACE         (128, 128, 128, 255)
BACKGROUND           (58, 110, 165, 255)
BTNFACE              (212, 208, 200, 255)
BTNHIGHLIGHT         (255, 255, 255, 255)
BTNHILIGHT           (255, 255, 255, 255)
BTNSHADOW            (128, 128, 128, 255)
BTNTEXT              (0, 0, 0, 255)
CAPTIONTEXT          (255, 255, 255, 255)
DESKTOP              (58, 110, 165, 255)
FRAMEBK              (212, 208, 200, 255)
GRADIENTACTIVECAPTION (166, 202, 240, 255)
GRADIENTINACTIVECAPTION (192, 192, 192, 255)
GRAYTEXT             (128, 128, 128, 255)
HIGHLIGHT            (10, 36, 106, 255)
HIGHLIGHTTEXT        (255, 255, 255, 255)
HOTLIGHT             (0, 0, 128, 255)
INACTIVEBORDER       (212, 208, 200, 255)
INACTIVECAPTION      (128, 128, 128, 255)
INACTIVECAPTIONTEXT  (212, 208, 200, 255)
INFOBK               (255, 255, 225, 255)
INFOTEXT             (0, 0, 0, 255)
LISTBOX              (255, 255, 255, 255)
LISTBOXHIGHLIGHTTEXT (255, 255, 255, 255)
LISTBOXTEXT          (0, 0, 0, 255)
MENU                 (212, 208, 200, 255)
MENUBAR              (212, 208, 200, 255)
MENUHILIGHT          (10, 36, 106, 255)
MENUTEXT             (0, 0, 0, 255)
SCROLLBAR            (212, 208, 200, 255)
WINDOW               (255, 255, 255, 255)
WINDOWFRAME          (0, 0, 0, 255)
WINDOWTEXT           (0, 0, 0, 255)

[Dietmar Schwertberger]

Fix is in repository. It will be part of 0.8.0b3.