#147 [wxTreeListCtrl] text search bugs

[Ronan Chartois]

on behalf of Robert Majewski:

I started to use your widget (ver. 1208), and I think some lines are incorrect:

treelistctrl.cpp:3223 int col, col_start, col_end;
treelistctrl.cpp:3224 if (column >= 0) { col_start = col_end = col; }

"col" is uninitialized, so it shouldn't be used as initializer for "col_start" and "col_end".

treelistctrl.cpp:3993 m_findStr.Append ((const char *)event.GetKeyCode());

event.GetKeyCode() returns int, so it shouldn't be casted to (const char*), my program crashed in this line.

[Ronan Chartois]

Fixed in SVN head.

- the first point would cause FindItem() to fail when searching on a specific column

- the second point was in itself just a bad cast, but made me realize that the keyboard search was actually not working properly:
- it would not always consider the entire tree, but would stop at the end of the tree
- it would not check the current item for match, but always jump to the next match

Thanks Robert for reporting the issues!

[Ronan Chartois]

no feedback in 3 weeks, closing