wsmanager-devel

[Wsmanager-devel] "collect windows" bad behavior patch

[Jason S. <je...@ya...>]

Hi all,

Collect windows will allow you to "strand" yourself....  if you're on the
second desktop, it will collect all windows to the first one before quitting,
then all your windows are out of reach, unless you re-run desktop manager. 
Attached is a simple fix, that does an instant transition to desktop 1 before
collecting windows.  It's a patch for Core/WorkspaceController.m.  It would be
great if this could wind up in the production copy of 0.52, now that
collect-windows is the de-facto quit-time behavior.

Jason


		
__________________________________
Do you Yahoo!?
New and Improved Yahoo! Mail - Send 10MB messages!
http://promotions.yahoo.com/new_mail 

Re: [Wsmanager-devel] "collect windows" bad behavior patch

[Ka-Hing C. <ka...@gm...>]

On Thu, 15 Jul 2004 19:12:54 -0700 (PDT), Jason Sonnenschein
<je...@ya...> wrote:
> Hi all,
> 
> Collect windows will allow you to "strand" yourself....  if you're on the
> second desktop, it will collect all windows to the first one before quitting,
> then all your windows are out of reach, unless you re-run desktop manager.
> Attached is a simple fix, that does an instant transition to desktop 1 before
> collecting windows.  It's a patch for Core/WorkspaceController.m.  It would be
> great if this could wind up in the production copy of 0.52, now that
> collect-windows is the de-facto quit-time behavior.

Shouldn't the "proper" behavior be collecting all windows to the
current desktop?

-khc

Re: [Wsmanager-devel] "collect windows" bad behavior patch

[Jason S. <je...@ya...>]

> 
> Shouldn't the "proper" behavior be collecting all windows to the
> current desktop?
> 
> -khc
> 

Either sounds good to me....  Not 100% sure how to code that...  I'm new to the
code.  Would it basically mean changing (in func collectWindows of
WorkspaceController.m)

Workspace *firstWorkspace = [self workspaceAtIndex: 0];

to

Workspace *currentWorkspace = [[WorkspaceController defaultController]
currentWorkspace];

then change each use of firstWorkspace, in this function, to currentWorkspace

? 

Jason


	
		
__________________________________
Do you Yahoo!?
New and Improved Yahoo! Mail - 100MB free storage!
http://promotions.yahoo.com/new_mail 

Re: [Wsmanager-devel] "collect windows" bad behavior patch

[Ka-Hing C. <ka...@gm...>]

On Sat, 17 Jul 2004 16:52:31 -0700 (PDT), Jason Sonnenschein
<je...@ya...> wrote:
> Either sounds good to me....  Not 100% sure how to code that...  I'm new to the
> code.  Would it basically mean changing (in func collectWindows of
> WorkspaceController.m)
> 
> Workspace *firstWorkspace = [self workspaceAtIndex: 0];
> 
> to
> 
> Workspace *currentWorkspace = [[WorkspaceController defaultController]
> currentWorkspace];
> 
> then change each use of firstWorkspace, in this function, to currentWorkspace
> 
> ?

I took a quick look, and that seems to be reasonable to me. I think
this is better because, say when I quit desktop manager by logging
out, I probably don't care to see the rotating cube (or any other
animation). Also in that function there are two unnecessary
assignments for the loop variables.

Either way, whatever it does doesn't really matter to me, since I
don't quit desktop manager until I logoff anyways, or if it crashes.
Hmm, is there a way for a Cocoa app to add some code for crash
handling?

[Off topic]: Should it be called WSManager or Desktop Manager? I found
myself using it interchangably all the time...

-khc

Re: [Wsmanager-devel] "collect windows" bad behavior patch

[Jason S. <je...@ya...>]

OK.

Here's a working patch that behaves as Ka-Hing asked.  FYI... the original did
no transition effects, no matter what your preferences (no spinning cube, etc.)

Jason


		
__________________________________
Do you Yahoo!?
Vote for the stars of Yahoo!'s next ad campaign!
http://advision.webevents.yahoo.com/yahoo/votelifeengine/

Re2: [Wsmanager-devel] "collect windows" bad behavior patch

[Jason S. <je...@ya...>]

This patch is a little better than the last... forgot to skip over the current
workspace in the loop in the last patch, so this one is probably a little more
efficient.

Jason


		
__________________________________
Do you Yahoo!?
New and Improved Yahoo! Mail - Send 10MB messages!
http://promotions.yahoo.com/new_mail