Re: [Wrapper-user] 2 issues...

[Leif M. <le...@ta...>]

Jan,

> Java Service Wrapper is really brilliant software! (Will for sure 
> donate if we make money :-)

Thanks we would appreciate that. :-)

> It took me 4 hours to implement it with my server, but sadly I did 
> spend 3 hours searching for a bug which is in the docs
> http://wrapper.tanukisoftware.org/doc/english/integrate-start-stop-win.html
> on this page "wrapper.app.parameter.4" is missing in all samples which 
> causes the service fail to start ! (it stops processing after parameter 3)

Sorry about that...  Not sure how I missed that, but thanks for 
reporting it.  I've
got it fixed in CVS and will get the web site updated.  The release docs 
will be
updated in the next release.

>  I also noticed that placing quotes is not handled transparently:
> OK:wrapper.java.library.path.1=C:\Program Files\Servoy\service
> BAD:wrapper.java.library.path.1="C:\Program Files\Servoy\service"

I need to add some checks to make sure that the user never quotes this
property.  In your example, it is simple, but when there are multiple 
library
path entries, the entire library path needs to be quoted.  Having the
individual elements quoted will not work.   The Wrapper builds up the entire
path and then wraps the whole thing in quotes to make things work correctly
with paths containing spaces.  This is also an issue with the classpath
properties.
I added a note to the docs for both properties to make this usage a little
more clear.

> OK:wrapper.java.additional.1=-Duser.dir="C:\Program Files\Servoy"
> BAD:wrapper.java.additional.1=-Duser.dir=C:\Program Files\Servoy

This is described in the docs for this property.  I need to add a check
to make sure that the Wrapper warns the user if they specify a java
additional property that contains unquoted spaces.  You will have the
same issue with the app parameter properties.

I am always looking to improve the documentation.  So please let me
know if you find any other areas that are confusing.

Cheers,
Leif