Re: [Wrapper-user] Question about release notes

[Christian M. <chr...@ta...>]

Hello Ian,

thank you for your mail.

During a code review for version 3.3.6 we noticed that the Wrapper was not
checking the return value on the Windows API call SetConsoleCtrlHandler()
which registers and adds the control handler for the JVM.
I have actually never heard of any case where that function would fail.
Anyways in generas it is always a good idea to check the return value of a
function and print out a error message to the log. And if it really would
have failed before, then the control handler wasn't working and also no
indication about that written in the log file, which makes it then quite
difficult to tell from looking at the log file, what went wrong.

Hope this information helps you out.

Cheers,

Christian

On Fri, Aug 10, 2012 at 12:58 AM, <iko...@ax...> wrote:

> Hello,****
>
> I have a question regarding a fix done in version 3.3.6. In the release
> notes the fix notes state:****
>
> ** **
>
> - Fix a potential problem on Windows platforms where a failure to register
> the control handler was not being logged. If this happened, user logoffs
> would not be trapped correctly but no other problems would have occurred.*
> ***
>
> ** **
>
> The first sentence seems to imply that there are conditions where the
> handler cannot be registered and the problem that was fixed was that now
> that condition is logged whereas before it was not.  The second sentence
> seems to explain the effects of the handler not being registered correctly
> but it is not evident from those two sentences that there is now a fix to
> ensure that the handler is in fact registered correctly.****
>
> ** **
>
> My questions are, did this above fix ensure that the control handler is
> registered correctly or are there certain conditions under which the
> handler would not be registered and how likely it is to occur?  Is it
> limited to certain circumstances or environments?****
>
> ** **
>
> Thanks,****
>
> Ian Koelliker****
>
> ** **
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Wrapper-user mailing list
> Wra...@li...
> https://lists.sourceforge.net/lists/listinfo/wrapper-user
>
>