SourceForge has been redesigned. Learn more.
Close

#122 Configuration file parameters can overwrite each other

v3.2.3
open
5
2010-08-13
2010-08-11
No

For example,
wrapper.java.additional.1=parameter
wrapper.java.additional.2=parameter2

First line overwrite the second one, where at least it should report that in the log, as a warning or an error.

Discussion

  • Leif Mortenson

    Leif Mortenson - 2010-08-12
    • assigned_to: nobody --> mortenson
    • status: open --> open-works-for-me
     
  • Leif Mortenson

    Leif Mortenson - 2010-08-12

    The configuration files are intentionally designed so that a given property can be overwritten by a later line. This is done so that include files can be used to create customer configurations.

    If the property names are the same then this should happen. For example. In the following case, the second declaration of the property would be used. The first is overwritten:
    ---
    wrapper.java.additional.1=parameter
    wrapper.java.additional.1=parameter2
    ---

    In the example that you posted the property names are different, so they should both be preserved. Are you sure that the example you sent is correct?
    ---
    wrapper.java.additional.1=parameter
    wrapper.java.additional.2=parameter2
    ---

    Cheers,
    Leif

     
  • Sami Rishmawi

    Sami Rishmawi - 2010-08-12

    Sorry, bad example; the one you posted is correct.
    At least there should be a warning log saying that a parameter was overwritten.

     
  • Leif Mortenson

    Leif Mortenson - 2010-08-13
    • milestone: 651827 --> v3.2.3
    • labels: 906119 -->
     
  • Leif Mortenson

    Leif Mortenson - 2010-08-13
    • labels: --> Configuration
    • status: open-works-for-me --> open
     
  • Leif Mortenson

    Leif Mortenson - 2010-08-13

    Sami,
    I implemented a new Configuration directive for 3.6.0 which will cause the Wrapper to output information about properties whose values are overwritten. Just add the following to the top of your configuration file:

    #properties.debug

    Cheers,
    Leif

     

Log in to post a comment.