Some checks for return codes are missing.
Examples:
Would you like to add more error handling for return values from "malloc" like in the function "setLogfilePath" and from "pthread_mutex_lock" in the function "lockLoggingMutex"?
http://wrapper.svn.sourceforge.net/viewvc/wrapper/trunk/wrapper/src/c/logger.c?revision=1273&view=markup
Logged In: YES
user_id=228081
Originator: NO
Will do. I do check them in a lot of places, but I know it is not near 100%.
Did you notice this because of a code review, or were you experiencing some problems?
Cheers,
Leif
Logged In: YES
user_id=572001
Originator: YES
I spot this open issue by my little review.
It is popular to ignore error codes from such functions.
Logged In: YES
user_id=228081
Originator: NO
Checks have been added throughout the codebase.
These changes will be in the next release.
Cheers,
Leif
Logged In: YES
user_id=572001
Originator: YES
There are more unchecked function calls to fix.
Examples:
- fclose
- printf (Would you like to replace it by "perror()"?)