From: Daniel T. <dan...@st...> - 2003-08-29 12:59:17
|
ro...@kr... wrote: >>This version is working correctly. Have you made some experimental (or even >>expected) fixes in this version or could this be a side effect of the >>tracing? > > > As far as I know only 2 things have been changed since 1.4.0: a crash logger has been > added and multi-head should work now (in pre2 multihead is accidentally disabled...). I > hope trace logging has no side effect... > > In workrave.org/files, you can also find a pre1 version. workrave-1.4.1-pre1-nomulti.exe > has multi head support disabled and has no trace logging. workrave-1.4.1-pre1.exe has > broken multihead support and tracing logging. Perhaps one of these executable crashes. > As soon as I have time, I will create a pre3 with multihead enabled (both with and > without trace logging). Right then ... I have looked at both versions. -nomutli works correctly. pre1 crashes on startup - both log files are attached. Having browsed the web CVS I have made a guess at whats going on. GUI::init_multihead() calls init_multihead_mem(1) when enum_monitors is NULL. However before making the call it sets num_heads to 1 which makes init_multihead_mem(1) effectively a nop. I believe the crash is caused because heads is never allocated (init_multihead_mem() would have done this if enum_monitors was not NULL). I think the line that sets num_heads should be removed (however I have only read three functions from the entire code base so I could easily be wrong). Cheers Daniel --xx-- -- Daniel Thompson (STMicroelectronics) <dan...@st...> 1000 Aztec West, Almondsbury, Bristol, BS32 4SQ. 01454 462659 Tech Support: "I need you to boot the computer." Customer: (THUMP! pause) "No that hasn't helped." |