Originally created by: Ujjwaljain16
Fixes [#3400]
This PR resolves a mismatch between the declared CleanupResult type and the actual runtime behavior of PrecacheController.activate().
Currently:
deletedCacheRequestsdeletedURLsdeletedURLsThis leads to an inconsistent public API where TypeScript users are guided to use a property that does not exist at runtime.
Align runtime and types
deletedURLs is now treated as the canonical field
Add backward compatibility
deletedCacheRequests is returned as an alias pointing to the same array
Update type definition
Include both fields in CleanupResult
deletedCacheRequests as deprecatedUpdate JSDoc
Reflect deletedURLs as the primary field
deletedCacheRequestsAdd test coverage
Verify both deletedURLs and deletedCacheRequests return consistent values
deletedURLs as the de facto APIdeletedCacheRequests from types would break existing TypeScript usersThis approach:
deletedCacheRequests is now deprecated and can be removed in a future major releasedeletedURLs is more semantically accurate (array of URL strings rather than Request objects)Low , this is an additive, backward-compatible change with no impact on runtime logic or precaching behavior
Originally posted by: google-cla[bot]
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Originally posted by: Ujjwaljain16
waiting for the review
Originally posted by: Ujjwaljain16
@swissspidy can i get the review?
Originally posted by: Ujjwaljain16
CI test failing due to version mismatch unrelated to my changes
Originally posted by: swissspidy
Thanks for the PR. I don't have much capacity right now, but that unrelated test failure would definitely need fixing first in another PR.