fix(workbox-build): make source map filename consistent with injected source file

Brought to you by: tomkozak

#3234 fix(workbox-build): make source map filename consistent with injected source file

Status: open

Owner: nobody

Labels: None

Updated: 2026-05-04

Created: 2023-07-28

Creator: Anonymous

Private: No

Originally created by: steverep

Fixes [#3233] per comments on [#2239]

Name the output source map simply swDest with .map appended
Replace the sourceMappingURL comment with the new filename
Adjust tests to use different filenames for input and output
Add simple test to check URL replacement

Related

Tickets: ~~#2239~~
Tickets: #3233

Discussion

Anonymous - 2023-09-11

Originally posted by: steverep

@jeffposnick would it be possible to get your review here? I just don't want to build a pipeline using this patch if you feel it's a no go.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2023-09-11

Originally posted by: jeffposnick

CC: @tropicadri and @petele for guidance.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2023-11-24

Originally posted by: steverep

At this point I'm wondering if workbox is even being maintained anymore? It hasn't been touched in 6 months even for just responding to issues and dependency bumps.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2024-06-06

Originally posted by: steverep

@tomayac any chance this could get looked at soon? It's not exactly a very taxing review.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2024-06-06

Originally posted by: tomayac

@tomayac any chance this could get looked at soon? It's not exactly a very taxing review.

At first sight this LGTM, but the tests fail. Could you look if it's related to this change? Thanks!

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2024-06-06

Originally posted by: steverep

At first sight this LGTM, but the tests fail. Could you look if it's related to this change? Thanks!

I know they passed locally when I first created the PR but I'll take a quick look.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2024-06-06

Originally posted by: steverep

The same 8 tests fail on the v7 branch, so they have nothing to do with these changes.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2024-06-06

Originally posted by: tomayac

The same 8 tests fail on the v7 branch, so they have nothing to do with these changes.

Thanks for checking! @tropicadri, over to you for a final look. I LGTM.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2024-06-19

Originally posted by: steverep

@tropicadri are you able to review and release this change? I'd like to avoid creating a patch if I can.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.