Originally created by: roikoren755
Prior to filing a PR, please:
gulp build && gulp lint test passes locally.R: @jeffposnick @tropicadri
Fixes [#2478]
Description of what's changed/fixed.
This is a work in progress.
Couldn't get tests to run locally, and there are some @ts-ignore comments littered about in places that import things from workbox-build or workbox-google-analytics that I couldn't quite figure out.
I think getting this package to use the new TS version of workbox-build would get it almost ready to merge 🤞.
Feel free to push changes, or point me in the right direction to fix things :)
Originally posted by: tropicadri
@roikoren755 Thank you for this, sorry for the late reply we've been doing some upgrading of TS lint and as you saw workbox-build migration to TS, I'll take a look at the PR and help where I can :)
Originally posted by: tropicadri
This is far from ready, but I wanted to share the updates.
Let me know if you have any questions, thank you for your patience with this one.
Originally posted by: jeffposnick
Thanks! I'll take a look at this soon.
Ticket changed by: jeffposnick