Menu

#2882 feat: migrate workbox-webpack-plugin to typescript

closed
nobody
None
2022-02-18
2021-07-04
Anonymous
No

Originally created by: roikoren755

Prior to filing a PR, please:

  • open an issue to discuss your proposed change.
  • ensure that gulp build && gulp lint test passes locally.

R: @jeffposnick @tropicadri

Fixes [#2478]

Description of what's changed/fixed.
This is a work in progress.
Couldn't get tests to run locally, and there are some @ts-ignore comments littered about in places that import things from workbox-build or workbox-google-analytics that I couldn't quite figure out.

I think getting this package to use the new TS version of workbox-build would get it almost ready to merge 🤞.

Feel free to push changes, or point me in the right direction to fix things :)

Related

Tickets: #2478
Tickets: #3019

Discussion

  • Anonymous

    Anonymous - 2021-07-20

    Originally posted by: tropicadri

    @roikoren755 Thank you for this, sorry for the late reply we've been doing some upgrading of TS lint and as you saw workbox-build migration to TS, I'll take a look at the PR and help where I can :)

     
  • Anonymous

    Anonymous - 2021-09-04

    Originally posted by: tropicadri

    This is far from ready, but I wanted to share the updates.

    • I merged with v6 branch that has the latest eslint version, we don't use @ts-ignore when we need to disable eslint we use // eslint-disable...
    • I reused the types from workbox-build instead of creating new ones
    • I setup the build to use compile with Typescript
    • Still fixing tests.

    Let me know if you have any questions, thank you for your patience with this one.

     
  • Anonymous

    Anonymous - 2022-01-12

    Originally posted by: jeffposnick

    Thanks! I'll take a look at this soon.

     
  • Anonymous

    Anonymous - 2022-02-18

    Ticket changed by: jeffposnick

    • status: open --> closed
     

Log in to post a comment.