Menu

#2865 fix: Add `matchOptions` to `runtimeCaching.options.expiration` scheme

closed
nobody
None
2021-06-17
2021-06-12
Anonymous
No

Originally created by: cawa-93

Prior to filing a PR, please:

  • open an issue to discuss your proposed change.
  • ensure that gulp build && gulp lint test passes locally.

R: @jeffposnick @tropicadri

Fixes [#2864]

Description of what's changed/fixed.
Add matchOptions to runtimeCaching.options.expiration scheme

Related

Tickets: #2864

Discussion

  • Anonymous

    Anonymous - 2021-06-15

    Originally posted by: jeffposnick

    Thanks for the contribution—unfortunately, we've got a very large PR out for review now that migrates workbox-build to TypeScript. As part of this migration, the way options are set and validated has changed.

    This specific PR won't work with the planned changes, but I'll leave the underlying issue open. If you want to submit a new PR against the TypeScript codebase once [#2867] is merged, you're welcome to—otherwise, someone else from the project can make that change.

     

    Related

    Tickets: #2867

  • Anonymous

    Anonymous - 2021-06-15

    Ticket changed by: jeffposnick

    • status: open --> closed
     

Log in to post a comment.