Menu

#2806 [workbox-build] Uses old deprecated @hapi/joi

closed
nobody
2021-06-17
2021-04-07
Anonymous
No

Originally created by: KevinGruber

Welcome! Please use this template for reporting bugs or requesting features. For questions about using Workbox, the best place to ask is Stack Overflow, tagged with [workbox]: https://stackoverflow.com/questions/ask?tags=workbox

Library Affected:
workbox-build, workbox-webpack-plugin

Browser & Platform:
Webpack

Issue or Feature Request Description:
workbox-build is currently using a dep of @hapi/joi which is deprecated and just joi should be used now. Because it still uses @hapi/joi in version 16. which is also old it has a dep to topo 3.x which is incompatible with the new 5.x version. Because of structuring of my packages it is now installing the wrong topo into my project. Would be cool to switch to the "real" dep.*

When reporting bugs, please include relevant JavaScript Console logs and links to public URLs at which the issue could be reproduced.

Related

Tickets: #2867

Discussion

  • Anonymous

    Anonymous - 2021-04-07

    Originally posted by: jeffposnick

    Apologies for the inconvenience that this might be causing.

    We're in the midst of rewriting workbox-build in TypeScript, and as part of that conversion, we'll be moving from @hapi/joi to auto-generated validation logic based on the TypeScript definitions.

    Once that's complete, this should no longer be an issue. Thanks for your patience in the meantime.

     
  • Anonymous

    Anonymous - 2021-04-07

    Originally posted by: KevinGruber

    Hi :-)

    Thanks for answering and awesome to hear.
    I am looking forward to that 👍

     
  • Anonymous

    Anonymous - 2021-06-17

    Ticket changed by: jeffposnick

    • status: open --> closed
     

Log in to post a comment.