From: <anj...@t-...> - 2002-07-15 20:38:46
|
Hi Max, Am 15.07.2002 20:34 Uhr schrieb "Max Muller" unter <Max...@ma...>: > Da bug is dead Jim. Kewl:) > > Also I have removed all of the D2W references from ERExtensions, except > for one ERXValidation. ERXValidation uses the d2wContext to make pretty > display names for a given propertyKey and a given entity. My suggestion > for getting rid of the D2W reference in this case is instead use the > method displayNameForKey off of EOClassDescription to create the pretty > name. We already have a custom EOEntityClassDescription subclass, so we > can use the same logic for creating the pretty name (move > displayNameForPropertyKey from ERD2WUtilities down to ERXStringUtiliites > or some such place). I know that ERXValidation isn't being used as much > now that we have the validation factory in place (or is it?), so maybe > in the future to simplify things a bit we can drop ERXValidation > altogether. Any thoughts? Yes, please stop my head from hurting :) - I'm all for moving stuff from ERXUtilities to the respective foundation Utilities. I have some fixes for Array and Dictionary scheduled myself, but only after things cool down a bit. ERXValidation has to stay for now because as far as I recall the validation mechanism depends on it. > On Monday, July 15, 2002, at 10:06 AM, Patrice Gautier wrote: >> mystery solved: you were actually hitting a bug in the way ERD2WModel >> which was affecting not qualifiers (the rule that you listed had a not >> qualifier). Sorry, but I'm not sure what you mean? From what Max wrote, it's not a good idea to have object.somekey in my LHS, so doing it with the ERDDelayedBooleanAssignment seems like the best solution to me regardless whether it should have worked or not. >> The fix is simple and Max will be submitting it shortly. >> Also, we are going to move ERXQualifierTraversal and >> ERXQualifierTraversalCallback to ERDirectToWeb. After this is done, you >> should be able to revert to the old rule (without the delayed >> assignment) and it should work.. I have my app's "final" revision scheduled on Friday, so you forgive me if I'm reluctant to try new fixes that involve checking out the odd 30 classes Max has changed today:) I think I'll do fine with what I have but am sure to take a look at it as soon as I can. Cheers, Anjo |