Re: [Wonder-disc] ERPDFWrapper and ampersands in URLs

[Q <qd...@gm...>]

On 30/06/2011, at 8:55 PM, Paul Hoadley wrote:

> On 30/06/2011, at 7:42 PM, Q wrote:
> 
>>> A two line patch to ERXMutableURL.queryParametersAsString(StringBuffer) did work: replace the two calls to sb.append('&') with sb.append("&").  I'm fairly sure that's the correct syntax for all flavours of HTML, but is that likely to make any browsers and/or existing code explode?  That is, should I submit this patch to ERXMutableURL, or should I be looking at creating my own subclass just for this particular purpose?
>> 
>> Wrap it in a property so people can turn it off if it causes them issue, put it into the javadoc and submit a patch.
> 
> http://issues.objectstyle.org/jira/browse/WONDER-721

After looking at this a little closer, I think my suggestion to submit a patch based on this solution was perhaps a little premature, ERXMutableURL is intended to have the same contract as java.net.URL, and therefore shouldn't be escaping url's, it is the responsibility of the caller to do that. So while this resolves your issue, the proper fix should happen in GCAbstractChart.

-- 
Seeya...Q

Quinton Dolan - qd...@gm...
Gold Coast, QLD, Australia (GMT+10)