Re: [Wonder-disc] Can't compile Adaptor on CentOS

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 454-5900

i just committed a fix to the 5.4 branch

On Sep 29, 2010, at 3:33 PM, Ken Anderson wrote:

> Simon,
> 
> I said I would put a patch together that worked for Mac OS X and Linux, but haven't had the time.
> 
> Ken
> 
> On Sep 29, 2010, at 2:41 PM, Simon wrote:
> 
>> hi mike - did you get chance to revert that patch ? i still can't
>> build on linux using latest 54 builds.
>> 
>> simon
>> 
>> On 22 September 2010 17:52, Mike Schrag <ms...@po...> wrote:
>>> For now, I'll just revert that patch in the trunk version.
>>> 
>>> ms
>>> 
>>> On Sep 22, 2010, at 11:38 AM, Aurélien Minet wrote:
>>> 
>>>> Mike, sorry for the miss-understating of "did someone submit a patch for this?"
>>>> 
>>>> As I understand the problem is to have a portable random number generator ? (nothing specific for OS X, *BSD, Linux,
>>>> Solaris, Windows).
>>>> 
>>>> Apache provide stuff for that http://apr.apache.org/docs/apr/1.3/group__apr__random.html
>>>> so half solution is to have random.c becoming specific to webserver, other adaptor may be stick with srand();
>>>> as a result only Apache would have better random seed for the random balancer thanks to apr.
>>>> 
>>>> Aurélien
>>>> 
>>>> ps: C ANSI standard require having srand so it must be available on other OS
>>>> (in Linux stdlib.h srand call back srandom)
>>>> 
>>>> 
>>>> On 09/22/2010 03:35 PM, Stefan Klein wrote:
>>>>> Hi,
>>>>> 
>>>>> I  don't want to break into your discussion, but did you notice
>>>>> http://issues.objectstyle.org/jira/browse/WONDER-598 ?
>>>>> That patch contains also Mikes code changes.
>>>>> Under Windows the call of srand is needed cause the other two functions
>>>>> are unknown in VS.
>>>>> 
>>>>> Stefan
>>>>> 
>>>>> Am 22.09.10 15:01, schrieb Ken Anderson:
>>>>>> No worries, I understand, but I don't want to just change it back, so I wanted to know what environment the mod was meant for so I can make sure it stays included properly.
>>>>>> 
>>>>>> On Sep 22, 2010, at 8:54 AM, Michael Schrag wrote:
>>>>>> 
>>>>>>> No, I know the change that caused you trouble came from us, I meant a patch to make it also work on Linux ...
>>>>>>> 
>>>>>>> Sent from my iPad
>>>>>>> 
>>>>>>> On Sep 22, 2010, at 7:14 AM, Ken Anderson<ken...@an...>  wrote:
>>>>>>> 
>>>>>>>> It was Mike... :)
>>>>>>>> 
>>>>>>>> r11129 | mschrag | 2010-08-17 00:22:19 -0400 (Tue, 17 Aug 2010) | 3 lines
>>>>>>>> 
>>>>>>>> Use a better random seed for the random balancer in mod_WebObjects
>>>>>>>> 
>>>>>>>> 
>>>>>>>> Mike, what OS did this work on?  It was only a month ago...
>>>>>>>> 
>>>>>>>> Ken
>>>>>>>> 
>>>>>>>> On Sep 22, 2010, at 4:40 AM, Aurélien Minet wrote:
>>>>>>>> 
>>>>>>>>> On 09/21/2010 04:08 PM, Mike Schrag wrote:
>>>>>>>>>> did someone submit a patch for this?
>>>>>>>>> 
>>>>>>>>> about 7 or 8 month ago in random.c there was:
>>>>>>>>> 
>>>>>>>>> static int rnd_initialize(strtbl *options)
>>>>>>>>> {
>>>>>>>>> int ret = 0;
>>>>>>>>> time_t now;
>>>>>>>>> time(&now);
>>>>>>>>> srandom(now);
>>>>>>>>> return ret;
>>>>>>>>> }
>>>>>>>>> 
>>>>>>>>> no problem with that one which is not the case with the actual code:
>>>>>>>>> 
>>>>>>>>> static int rnd_initialize(strtbl *options)
>>>>>>>>> {
>>>>>>>>> int ret = 0;
>>>>>>>>> #if defined(WIN32)
>>>>>>>>> time_t now;
>>>>>>>>> time(&now);
>>>>>>>>> srand(now);
>>>>>>>>> #else
>>>>>>>>> srandomdev();
>>>>>>>>> #endif
>>>>>>>>> return ret;
>>>>>>>>> }
>>>>>>>>> 
>>>>>>>>> Sorry I haven't take the time to track the commits in SVN to find the reason of the change.
>>>>>>>>> 
>>>>>>>>> 
>>>>>>>>> Aurelien
>>>>>>>>> 
>>>>>>>>> ------------------------------------------------------------------------------
>>>>>>>>> Start uncovering the many advantages of virtual appliances
>>>>>>>>> and start using them to simplify application deployment and
>>>>>>>>> accelerate your shift to cloud computing.
>>>>>>>>> http://p.sf.net/sfu/novell-sfdev2dev
>>>>>>>>> _______________________________________________
>>>>>>>>> Wonder-disc mailing list
>>>>>>>>> Won...@li...
>>>>>>>>> https://lists.sourceforge.net/lists/listinfo/wonder-disc
>>>>>>>> 
>>>>>>>> ------------------------------------------------------------------------------
>>>>>>>> Start uncovering the many advantages of virtual appliances
>>>>>>>> and start using them to simplify application deployment and
>>>>>>>> accelerate your shift to cloud computing.
>>>>>>>> http://p.sf.net/sfu/novell-sfdev2dev
>>>>>>>> _______________________________________________
>>>>>>>> Wonder-disc mailing list
>>>>>>>> Won...@li...
>>>>>>>> https://lists.sourceforge.net/lists/listinfo/wonder-disc
>>>>>> 
>>>>>> ------------------------------------------------------------------------------
>>>>>> Start uncovering the many advantages of virtual appliances
>>>>>> and start using them to simplify application deployment and
>>>>>> accelerate your shift to cloud computing.
>>>>>> http://p.sf.net/sfu/novell-sfdev2dev
>>>>>> _______________________________________________
>>>>>> Wonder-disc mailing list
>>>>>> Won...@li...
>>>>>> https://lists.sourceforge.net/lists/listinfo/wonder-disc
>>>>>> 
>>>>> 
>>>>> ------------------------------------------------------------------------------
>>>>> Start uncovering the many advantages of virtual appliances
>>>>> and start using them to simplify application deployment and
>>>>> accelerate your shift to cloud computing.
>>>>> http://p.sf.net/sfu/novell-sfdev2dev
>>>>> _______________________________________________
>>>>> Wonder-disc mailing list
>>>>> Won...@li...
>>>>> https://lists.sourceforge.net/lists/listinfo/wonder-disc
>>>> 
>>>> 
>>>> ------------------------------------------------------------------------------
>>>> Start uncovering the many advantages of virtual appliances
>>>> and start using them to simplify application deployment and
>>>> accelerate your shift to cloud computing.
>>>> http://p.sf.net/sfu/novell-sfdev2dev
>>>> _______________________________________________
>>>> Wonder-disc mailing list
>>>> Won...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/wonder-disc
>>> 
>>> 
>>> ------------------------------------------------------------------------------
>>> Start uncovering the many advantages of virtual appliances
>>> and start using them to simplify application deployment and
>>> accelerate your shift to cloud computing.
>>> http://p.sf.net/sfu/novell-sfdev2dev
>>> _______________________________________________
>>> Wonder-disc mailing list
>>> Won...@li...
>>> https://lists.sourceforge.net/lists/listinfo/wonder-disc
>>> 
>> 
>> ------------------------------------------------------------------------------
>> Start uncovering the many advantages of virtual appliances
>> and start using them to simplify application deployment and
>> accelerate your shift to cloud computing.
>> http://p.sf.net/sfu/novell-sfdev2dev
>> _______________________________________________
>> Wonder-disc mailing list
>> Won...@li...
>> https://lists.sourceforge.net/lists/listinfo/wonder-disc
> 