Re: [Wonder-disc] [Wonder-cvs] SF.net SVN: wonder:[8172] trunk/Wonder/Frameworks/Core/ERExtensions/Sources /er/extensions/components/_private/ERXWOForm.java

[Timo H. <th...@on...>]

Hi Ravi,

WOForm breaks with rev 8172. It was previously changed in rev 8169.
ERXPatcher breaks with 8171. Previously changed in 7710.

When I revert the two files to that revisions, it compiles fine again.

Regarding 5.4-only changes: There is a seperate folder for sources in  
ERExtensions: Sources_WO54. I didn't take a look how the build system  
utilizes that, though...

Timo


Am 14.08.2008 um 11:43 schrieb Ravi Mendis:

> Hi Timo,
>
> Do you know if there is a branch of Wonder that's 5.4 only?
> These changes aren't really relevant to 5.3. (I forgot Wonder trunk  
> would still be compiled on 5.3 - i don't have a 5.3 system for me  
> to easily go in and see which changes are problematic).
>
> So, would you be able to tell me which commit numbers i need to  
> revert on the trunk so that the 5.3 people can build? (I know that  
> some of my XHTML commits would be backward compatible).
> i.e if you can apply them one by one (a la "svn merge -r  
> <revisionNo>:<revisionNo-1> <url>" to reverse an individual change).
>
> Thanks,
> Ravi
>
> On Thursday, August 14, 2008, at 11:05AM, "Timo Hoepfner" <th- 
> de...@on...> wrote:
>> Ravi,
>>
>> with this change, and the one to ERXPatcher, Wonder doesn't build
>> with 5.3.3 any more!
>>
>> [wocompile] Compiling 45 source files to /Network/Servers/
...
>> [wocompile] 7 errors
>>
>>
>> Timo
>>
>> Am 13.08.2008 um 13:45 schrieb rm...@us...:
>>
>>> +		if (useIdInsteadOfNameTag && _id != null) {
>>> +			_formName = _id;	// id takes precedence over name - then
>>> subsequently written as id
>>> +			_id = null;
>>> +		}
>>
>>
>>