Re: [Wonder-disc] ERD2WEditableListPage/ERD2WEditableListTemplate

[Anjo K. <kr...@lo...>]

> M Common/Frameworks/ERDirectToWeb/Components/Nonlocalized.lproj/ 
> ERD2WEditableListTemplate.wo/ERD2WEditableListTemplate.html
>
> Fix the end tag for the ListNotEmpty conditional, so that it does  
> not overlap the ListEmpty conditional (bug fix).
> Add ShouldShowMassChange conditional, which wraps the Mass Change  
> components.

Sure.

> M Common/Frameworks/ERDirectToWeb/Components/Nonlocalized.lproj/ 
> ERD2WEditableListTemplate.wo/ERD2WEditableListTemplate.wod
>
> Change the name of some components to be more meaningful
> Change the form to an ERXWOForm, with name "EditForm"  (this makes  
> some javascript components happier)

Please don't use ERXWOForm directly, use WOForm instead. It's patched  
into the runtime anyway...

> Add the mass change feature components
> 	repetition to show the property keys
> 	clear changes submit button
> 	propagate changes submit button
> 	debug conditionals
> 	debug output
>
> M Common/Frameworks/ERDirectToWeb/Components/Nonlocalized.lproj/ 
> ERDListPageRepetition.wo/ERDListPageRepetition.wod
>
> Change the PropertyName component to a ERD2WPropertyName from a  
> WOString, so we can have debug info when debugging is turned on

Sure, I never noticed this as I use my own reps in all my projects.

> M Common/Frameworks/ERDirectToWeb/Sources/er/directtoweb/ 
> ERD2WEditableListPage.java
>
> Add logger
> Mass change feature
> 	a generic record EO (of new class ERDMassChangeGenericRecord) with  
> class description of our current entity
> 	a display group with the generic record EO (mass change EO)
> 	support for applying and clearing changes on the mass change EO
>
> cancel() reverts the mass change EO editing context

OK... but isn't there already a ERDMassModifyButton?

> M Common/Frameworks/ERDirectToWeb/Sources/er/directtoweb/ 
> ERD2WPage.java
>
> add d2wDebuggingEnabled() convenience method

Sure.

> M Common/Frameworks/ERDirectToWeb/Sources/er/directtoweb/ 
> ERDEditDateJavascript.java
>
> In appendToResponse(), always update the displayed value instead of  
> only updating if the display value is null.  (bug fix)

Sure.

> A Common/Frameworks/ERDirectToWeb/Sources/er/directtoweb/ 
> ERDMassChangeGenericRecord.java
>
> Subclass of EOGenericRecord
> 	Could not get it to work as subclass of ERXGenericRecord, need to  
> use EOGenericRecord(EOClassDescription) constructor without  
> tripping the EOGenericRecord() constructor
> handleQueryWithUnboundKey() implemented to return null if the  
> requested key is not a property key
> has two committed snapshot convenience methods copied from  
> ERXGenericRecord

No comment, no idea :)


> BUGS
> 	mass change header columns should not show the sort icon

Fix this in the rules? (bla) => propertyIsSortable = false

> 	UI is not clear, could use some help
> TODO
> 	check for custom display property keys rule for the mass change EO  
> (to restrict the keys that can be edited)
> 	needs more testing

A screenshot would be nice.

But anyway, go ahead :)

Cheers, Anjo