RE: (UPDATE): Re: [WOLK-devel] [ANNOUNCE] WOLK v4.4s FINAL - Server Edition

[Mike B. <Mik...@fu...>]

> o   updated:  3com 3c59x v0.99Za (vanilla ones is over 2 years old)

Hi,
one thing with v4.4s: the updated 3c59x driver won't compile without =
loadable module support enabled:

gcc -D__KERNEL__ -I/opt/src/linux/include  -Wall -Wstrict-prototypes =
-Wno-trigraphs -fno-strict-aliasing -fno-common -Wno-unused =
-finline-limit=3D2000 -Os -fomit-frame-pointer -pipe =
-mpreferred-stack-boundary=3D2 -march=3Di686   -nostdinc -iwithprefix =
include -DKBUILD_BASENAME=3D3c59x  -c -o 3c59x.o 3c59x.c
3c59x.c:106:31: linux/modversions.h: No such file or directory
3c59x.c:728: `init_module' undeclared here (not in a function)
3c59x.c:729: `cleanup_module' undeclared here (not in a function)
make[3]: *** [3c59x.o] Error 1
make[3]: Leaving directory `/opt/src/linux-2.4.20-48c/drivers/net'
make[2]: *** [first_rule] Error 2
make[2]: Leaving directory `/opt/src/linux-2.4.20-48c/drivers/net'
make[1]: *** [_subdir_net] Error 2
make[1]: Leaving directory `/opt/src/linux-2.4.20-48c/drivers'
make: *** [_dir_drivers] Error 2

and this change as well:

--- drivers/net/3c59x.c.orig    Thu Jul 31 08:46:26 2003
+++ drivers/net/3c59x.c Thu Jul 31 08:47:02 2003
@@ -724,11 +724,6 @@ struct driver_operations vortex_ops =3D {
 #if defined(MODULE) || (LINUX_VERSION_CODE >=3D 0x020400)
-#if ! defined(MODULE)                  /* Must be a 2.4 kernel */
-module_init(init_module);
-module_exit(cleanup_module);
-#endif
-
 int init_module(void)
 {
        printk(KERN_INFO "%s" KERN_INFO "%s", versionA, versionB);
@@ -769,6 +764,11 @@ int tc59x_probe(struct net_device *dev)
                printk(KERN_INFO "%s" KERN_INFO "%s", versionA, =
versionB);
        return retval;
 }
+#if ! defined(MODULE)                  /* Must be a 2.4 kernel */
+module_init(init_module);
+module_exit(cleanup_module);
+#endif
+
 #endif  /* not MODULE */
 #if ! defined(CARDBUS) && ! defined(USE_MEM_OPS)


thanks for all the great fixes in this ver though,
mike