[Wixedit-devel] [ wixedit-Bugs-3401459 ] Reloading invalid files

[SourceForge.net <no...@so...>]

Bugs item #3401459, was opened at 2011-08-31 03:30
Message generated for change (Comment added) made by jaykee
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=726876&aid=3401459&group_id=133314

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: General
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Jasper Keuper (jaykee)
Assigned to: Jasper Keuper (jaykee)
Summary: Reloading invalid files

Initial Comment:
Reloading a invalid file results in the error below. Reloading should load in a differen XmlDocument and leave the current wxsDocument. When the load succeeds, then get rid of the wxsDocument and swap with the newly loaded XmlDocument.

See offending line in wixedit/src/Xml/WixFiles.cs: line 1046:
1041	                XmlNodeList list = wxsDocument.SelectNodes(String.Format("//{0}:*", theNodeNamespace), wxsNsmgr);
1042	                if (list.Count == 0)
1043	                {
1044	                    // Error reports show that a NullReferenceException occurs on the next line now, how can this be?
1045	                    // The wxsDocument.DocumentElement is null.
1046	                    wxsDocument.DocumentElement.RemoveAttribute(String.Format("xmlns:{0}", theNodeNamespace));
1047	                }

20110323180658 ---- Wed, 23 Mar 11 18:06:58 +0000 -----
Version 0.7.5.0
LastModified 2011-03-18T23:25:58Z
DateTime 2011-03-23T18:06:58Z

System.NullReferenceException: Object reference not set to an instance of an object.
   at WixEdit.Xml.WixFiles.Save() in c:\Users\Jasper\Documents\Visual Studio 2010\Projects\wixedit\src\Xml\WixFiles.cs:line 1046
   at WixEdit.EditorForm.Save() in c:\Users\Jasper\Documents\Visual Studio 2010\Projects\wixedit\src\EditorForm.cs:line 626
   at WixEdit.EditorForm.fileSave_Click(Object sender, EventArgs e) in c:\Users\Jasper\Documents\Visual Studio 2010\Projects\wixedit\src\EditorForm.cs:line 619
   at System.Windows.Forms.MenuItem.OnClick(EventArgs e)
   at System.Windows.Forms.MenuItem.MenuItemData.Execute()
   at System.Windows.Forms.Command.Invoke()
   at System.Windows.Forms.Command.DispatchID(Int32 id)
   at System.Windows.Forms.Control.WmCommand(Message& m)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ScrollableControl.WndProc(Message& m)
   at System.Windows.Forms.ContainerControl.WndProc(Message& m)
   at System.Windows.Forms.Form.WndProc(Message& m)
   at WixEdit.EditorForm.WndProc(Message& message) in c:\Users\Jasper\Documents\Visual Studio 2010\Projects\wixedit\src\EditorForm.cs:line 1734
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)


----------------------------------------------------------------------

>Comment By: Jasper Keuper (jaykee)
Date: 2012-09-26 02:38

Message:
Fixed, will be in next release.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=726876&aid=3401459&group_id=133314