[Wixedit-devel] [ wixedit-Bugs-2330080 ] Run VS Code Analysis and address at least the critical bugs

[SourceForge.net <no...@so...>]

Bugs item #2330080, was opened at 2008-11-22 17:51
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=726876&aid=2330080&group_id=133314

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Mike Smith-Lonergan (poseidoncoder)
Assigned to: Nobody/Anonymous (nobody)
Summary: Run VS Code Analysis and address at least the critical bugs

Initial Comment:
Running VS 2008 SP1's Code Analysis against the current source generates over 1300 Code Analysis warnings.  These include some of the most critical issues, such as:
- CA 1031 (~50 warnings) - code catches "Exception" or "(object)", thus effectively swallowing many exceptions that may not be adequately handled.
- CA 1051 - code exposes fields to external access, and should instead add a Get and/or Set property (and make the field private)
- CA 1060 - code that exposes P/Invoke methods should be separated into separate classes, and ideally into a separate assembly
- CA 2109 - a number of custom methods do not need to be externally visible (and may be creating some security risks)
- CA 2122 - method calls are being exposed to the risk of unexpected user input
- CA 2201 - code throws a generic "Exception" that should never be raised by user code (and has created the conditions that create some of the CA 1031 issues - i.e. it's possible that many of the CA 1031 issues would not need to be so generous, and could make it much easier to track down other unexpected exceptions).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=726876&aid=2330080&group_id=133314