Re: [WiX-devs] Qustion about wixca: XmlConfig:ReadXmlConfigTable, XmlFile:ReadXmlFileTable

[Hoover, J. <Jac...@gr...>]

https://sourceforge.net/tracker/?func=detail&aid=3524147&group_id=105970
&atid=642714

 

 

Logged, though the more I think of it if an allocation fails the
probability of the error message being able to print is quite low. I'd
guess in the case where the string copy fails for a reason other than an
out of memory error this would still be valid.

 

From: Bob Arnson [mailto:bo...@jo...] 
Sent: Sunday, May 06, 2012 11:41 AM
To: wix...@li...
Subject: Re: [WiX-devs] Qustion about wixca:
XmlConfig:ReadXmlConfigTable, XmlFile:ReadXmlFileTable

 

On 05-May-12 19:32, Hoover, Jacob wrote: 

When looking in to extending wixca to be able to read Xml settings, I
noticed something I thought was a bit strange. The ExitOnFailure1 calls
following StringCchCopyW and StrAllocString are using the variable that
we are attempting to populate. Would  not make more sense to be using
pwzData instead to show the value we were trying to copy/allocate?

Yes. Depending on the error, the destination might not have any useful
data. Please file a bug so we can track it.




-- 
sig://boB
http://joyofsetup.com/