A BinaryRef in the PatchFamily does not cause a row to be added for the Binary table. This means the Binary table cannot be patched. Patch.cs contains no references to the Binary table.
After additional testing, the reason is that binary streams are not cab'd into the wixpdb (the recommended way for patch build now). However, like with current qtests, when you output to .wixout (light -xo ...) the binary streams are cab'd and prepended to the .wixout.
This is broken, IMO, since if .wixpdbs are the way to patch you cannot use a BinaryRef. If you do, there is no warning or error - the Binary table row just doesn't end up in the authoring transform. We either need to err or put cabs into the .wixpdb (which increases disk usage when the .msi is already bound).
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Doesn't the patching process pick up the binary streams from the disk or does the source point to temp where the cab from the wixout is expected to be?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 21 days (the time period specified by
the administrator of this Tracker).
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Example source with BinaryRef
After additional testing, the reason is that binary streams are not cab'd into the wixpdb (the recommended way for patch build now). However, like with current qtests, when you output to .wixout (light -xo ...) the binary streams are cab'd and prepended to the .wixout.
This is broken, IMO, since if .wixpdbs are the way to patch you cannot use a BinaryRef. If you do, there is no warning or error - the Binary table row just doesn't end up in the authoring transform. We either need to err or put cabs into the .wixpdb (which increases disk usage when the .msi is already bound).
Doesn't the patching process pick up the binary streams from the disk or does the source point to temp where the cab from the wixout is expected to be?
Neither the path or the binary are stored in the wixpdb.
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 21 days (the time period specified by
the administrator of this Tracker).