#1322 Not all changed files are included in the patch by Pyro

[erikv]

With a large setup, differences of equal sized files detected and documented in the .wixmst file (MsiFileHash table) by Torch don't show up in the patch (and also not in the .wixpdb file). Unfortunately this issue seems to be specific to the setup file, since another project doesn't seem to have the same problem.

The following settings were used:
1.) torch.exe -p -xi D:\projects\mks\mts\sw\src\misc\setup\install_support\mts_revision\mtsv2setup.wixpdb D:\projects\mks\mts\sw\out\setup\mtsv2setup.wixpdb -out D:\projects\mks\mts\sw\out\setup\mtsv2sp2.wixmst -v -notidy
2.) candle.exe ...
3.) light.exe ...
4.) pyro.exe D:\projects\mks\mts\sw\out\setup\mtsv2sp2.wixmsp -out D:\projects\mks\mts\sw\out\setup\mtsv2sp2.msp -t MTS_System_2.2.221 D:\projects\mks\mts\sw\out\setup\mtsv2sp2.wixmst -sw1103 -v -notidy -reusecab

The .wixmst and the .wixpdb files are attached to the tracker issue.

Many files of equal size but different content should also have been included in the patch (for example: cdlimporter.pdb, sistorage.pdb, converter.pdb).

Used version of WIX is: 3.0.4429.0 (as well as 3.0.4318.0).

[erikv]

.wixmst and .wixpdb output of Torch and Pyro

[pmarcu]

Logged In: YES
user_id=1612676
Originator: NO

At the time you are running torch, are the different files still available on disk? In other words, when building your upgrade msi, are the target files being overwritten? The symptoms you are seeing usually happen in this case. The wixmst FileHash table is showing differences because it just diffs the tables in the msi's while pyro actually diffs the files on disk.

In the wixmst I see in the WixFile table that the file path to the file its going to diff is ......\out\bin\converter.pdb but there is no corresponding path to compare it to. I'm thinking its going to compare it to itself because the realtive path from the wixmst is going to point to the same file.

[erikv]

Logged In: YES
user_id=2200831
Originator: YES

Hi Peter,

thanks for the hint. You were right, the newer version of the file was compared with itself. As a consequence these files were not updated, since they did not differ. It took me a while to test and change this in the version management tool that uses the concept to compile every version to the same location. But it works and we now have a working patch.

[pmarcu]

Logged In: YES
user_id=1612676
Originator: NO

Good to hear. I'm going to close the bug.