#1187 v.4025:MsBuild throws InternalErrorException in second build

[MathiasH]

This became an issue in version 3.0.4025.0 of WiX after the "MsBuild 3.5 -> MsBuild 2.0" fix.

• The first time VS builds my Wix project, all goes well (= improvement over the previous drop).
• The second time the same VS process (re)builds the same Wix project (without restarting VS) I get the following exception:

Error 1 The build was aborted because of an internal failure.
Microsoft.Build.Shared.InternalErrorException: Internal MSBuild Error:
Project shouldn't be in ProjectManager already.
at Microsoft.Build.Shared.ErrorUtilities.ThrowInternalError(Boolean
showAssert, String unformattedMessage, Object[] args)
at Microsoft.Build.BuildEngine.Engine.BuildProject(Project project, String[] targetNames, IDictionary targetOutputs, BuildSettings buildFlags, Boolean fireProjectStartedFinishedEvents)
C:\Source\StingModules\AddinModule\AddinModule.csproj 0 1
SixEdgeSetupWix

Seems some in process state (in the MsBuild ProjectManager) remains between builds.

Sometimes I don't get the above exception, but instead the "The build was aborted because of an unexpected logger failure." problem, which is reported in another already filed bug.

I am using VS 2005 (8.0.50727.762 (SP.050727-7600) and .NET FW 2.0 with SP1.

[Jason Ginchereau]

Logged In: YES
user_id=2086430
Originator: NO

Doesn't repro for me on VS2005 w/ WiX 3.0.4123.

Do you see this error only for a certain solution, or with any WiX projects/solutions?

[MathiasH]

Logged In: YES
user_id=2079454
Originator: YES

I still get it (just tried and did), but I get the feel it is sometimes intermittent now (was very consistent). Note, I have still to upgrade from 4102.

I've only got it in the solution file I am working on, OTOH I have not tried any other solution/project. I'll see if I can get a minimal repro, if I do I'll post it.

Also, if I upgrade to the latest drop and it goes away, I'll post that too.

[MathiasH]

Logged In: YES
user_id=2079454
Originator: YES

Update: 10 days ago I upgraded to 3.0.4123.0. I still see both this exception (stack below) and the "unexpected logger" issue on a "second build". Still feels like it is somewhat intermittent.

Stack from today using 3.0.4123.0:
Error 1 The build was aborted because of an internal failure.
Microsoft.Build.Shared.InternalErrorException: Internal MSBuild Error: Project shouldn't be in ProjectManager already.
at Microsoft.Build.Shared.ErrorUtilities.ThrowInternalError(Boolean showAssert, String unformattedMessage, Object[] args)
at Microsoft.Build.BuildEngine.Engine.BuildProject(Project project, String[] targetNames, IDictionary targetOutputs, BuildSettings buildFlags, Boolean fireProjectStartedFinishedEvents) C:\Source\StingModules\AddinModule\AddinModule.csproj 0 1 SixEdgeSetupWix

Have tried to reproduce in a clean WiX solution "from scratch", but have not found a successful repro there. Currently I only get this problem in this one solution file that is pretty big. It has 14 C# projects in total with quite a few assembly dependencies.

[Jason Ginchereau]

Logged In: YES
user_id=2086430
Originator: NO

Are you running Code Analysis on any of your projects? Do you have a .cs file that is included as a link in multiple projects? If so then this is a known issue with Visual Studio that is unrelated to WiX projects. See http://connect.microsoft.com/VisualStudio/feedback/ViewFeedback.aspx?FeedbackID=330500

[MathiasH]

Logged In: YES
user_id=2079454
Originator: YES

Yes we do have such a .cs file related to AssemblyInfo stuff that is linked into a whole bunch of projects in the solution. We don't run code analysis using VS however (we use VS2k5 Pro in this iteration).

The problem only occurs when I right click on the wix project to rebuild it. Never when building the rest of the solution and the wix project thus is excluded from being built.

[Jason Ginchereau]

Logged In: YES
user_id=2086430
Originator: NO

Can you check whether this still bug is still reproducable on build 3.0.4214 or later? That build has a fix for a similar bug 1882870, and this error could be another symptom of the same issue which was fixed.

[Rob Mensching]

Logged In: YES
user_id=991639
Originator: NO

Resolving fixed since it is expected a recent build fixes this. If you still see the problem, please provide detailed repro steps so we can track it down further.

[MathiasH]

Logged In: YES
user_id=2079454
Originator: YES

Upgraded to 3.0.4415 today. Have (re)built same solution several times without problems. Appears to be resolved.

[Rob Mensching]

Logged In: YES
user_id=991639
Originator: NO

Thanks for confirmation. Closing this bug again since comments automatically reopen them.