#1170 dark throws exception on Control table

[Andrew Sampson]

Decompiling the CheckBox table.
Decompiling the Icon table.
Decompiling the ProgId table.
Decompiling the Class table.
Decompiling the ComboBox table.
Decompiling the Complus table.
Decompiling the Condition table.
Decompiling the Dialog table.
Decompiling the Control table.
dark.exe : error DARK0001 : Unable to cast object of type 'System.Int32' to type 'System.String'.

Exception Type: System.InvalidCastException

Stack Trace:
at Microsoft.Tools.WindowsInstallerXml.ControlRow.get_X()
at Microsoft.Tools.WindowsInstallerXml.Decompiler.DecompileControlTable(Table table)
at Microsoft.Tools.WindowsInstallerXml.Decompiler.DecompileTables(Output output)
at Microsoft.Tools.WindowsInstallerXml.Decompiler.Decompile(Output output)
at Microsoft.Tools.WindowsInstallerXml.Tools.Dark.Run(String[] args)

An example row in the Control table looked like this:
Dialog = 'Welcome_Dialog'
Control = 'Text1'
Type = 'Text'
X = 136
Y = 60
Width = 228
Height = 30
Attributes = 65539
Property = ""
Text = "Standard_Dialogue_BackGround"
Control Next = ""
Help = ""

[Andrew Sampson]

Logged In: YES
user_id=1939857
Originator: YES

If -sui is passed on the command line, dark will instead crash like this:
Decompiling the WiseCommandLine table.
C:\Projects\AndrewS\WixInstalls\MDref\MDRef.msi : warning DARK1060 : The WiseCommandLine table is being decompiled as a custom table.
Decompiling the WiseDlgSequence table.
C:\Projects\AndrewS\WixInstalls\MDref\MDRef.msi : warning DARK1060 : The WiseDlgSequence table is being decompiled as a custom table.
Decompiling the WiseFileHash table.
C:\Projects\AndrewS\WixInstalls\MDref\MDRef.msi : warning DARK1060 : The WiseFileHash table is being decompiled as a custom table.
Decompiling the WisePathVariable table.
C:\Projects\AndrewS\WixInstalls\MDref\MDRef.msi : warning DARK1060 : The WisePathVariable table is being decompiled as a custom table.
Decompiling the WiseVersionInfo table.
C:\Projects\AndrewS\WixInstalls\MDref\MDRef.msi : warning DARK1060 : The WiseVersionInfo table is being decompiled as a custom table.
dark.exe : error DARK0001 : Object reference not set to an instance of an object.

Exception Type: System.NullReferenceException

Stack Trace:
at Microsoft.Tools.WindowsInstallerXml.Decompiler.FinalizeCheckBoxTable(TableCollection tables)
at Microsoft.Tools.WindowsInstallerXml.Decompiler.FinalizeDecompile(TableCollection tables)
at Microsoft.Tools.WindowsInstallerXml.Decompiler.Decompile(Output output)
at Microsoft.Tools.WindowsInstallerXml.Tools.Dark.Run(String[] args)

Note that emptying the Control table of rows will prevent both of these exceptions.

[Bob Arnson]

Logged In: YES
user_id=26581
Originator: NO

The InvalidCastException bug is fixed but not the particular NullReferenceException. Can you attach a minimal Wise-generated .msi so we can reproduce?

[Andrew Sampson]

Minimal Wise MSI that installs 1 file

[Andrew Sampson]

Logged In: YES
user_id=1939857
Originator: YES

File Added: Minimal Wise.msi

[SourceForge Robot]

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 15 days (the time period specified by
the administrator of this Tracker).