#603 EndNote import doesn't set properly the creator order field

[Stéphane Aulery]

An EndNote import always sets the creator order to zero.

[Stéphane Aulery]

This error caused a string error in BibTeX key calculation because it always assumes there is a creator with an order of 1. I fixed the key calculation by sorting on order instead of making a condition. Only now I'm not sure if I should sort first by the resourcecreatorRole field or the resourcecreatorOrder field.

E.g

    SELECT
        COALESCE(creatorPrefix, '') AS creatorPrefix,
        COALESCE(creatorSurname, '') AS creatorSurname

    FROM resource_creator

        INNER JOIN creator
            ON resourcecreatorCreatorMain = creatorId
                AND TRIM(COALESCE(creatorSurname, '')) <> ''
                AND resourcecreatorResourceId = " . $id . "

    ORDER BY resourcecreatorRole, resourcecreatorOrder, TRIM(COALESCE(creatorSurname, ''));

OR ?

    SELECT
        COALESCE(creatorPrefix, '') AS creatorPrefix,
        COALESCE(creatorSurname, '') AS creatorSurname

    FROM resource_creator

        INNER JOIN creator
            ON resourcecreatorCreatorMain = creatorId
                AND TRIM(COALESCE(creatorSurname, '')) <> ''
                AND resourcecreatorResourceId = " . $id . "

    ORDER BY resourcecreatorOrder, resourcecreatorRole, TRIM(COALESCE(creatorSurname, ''));

[Mark Grimshaw]

Hi Stéphane,

Ordering in the listing of resources by creator is:
ORDER BY resourcecreatorRole, resourcecreatorOrder

so your first example should be the correct one. 'creatorRole' is, for a book, author, editor, translator, reviser, series editor in that order of priority. 'creatorOrder' is the order of creators within each role. In practice, though, it becomes quite arbitrary whether a translator is more important in the order than a series editor but certainly author then editor should be used for ordering before other roles are considered.

Mark

[Stéphane Aulery]

Ok, resourcecreatorRole, resourcecreatorOrder is the current sort. The thing I'm wondering is how to guarantee that the most important author is always first so that the key and the formatting is correct, and that it is stable, without major modification.

For each type of resource type you display a different creator name/label for author role. E.g. If book, creator role 1 is a creator, if resource type is a film, creator role 1 is a director?

[Mark Grimshaw]

It's all controlled through core/resources/RESOURCEMAP.php (some of the comments might need updating).

e.g., book type has this:

            'resourcecreator' => [
                'Creator1' => 'author',
                'Creator2' => 'editor',
                'Creator3' => 'translator',
                'Creator4' => 'reviser',
                'Creator5' => 'seriesEditor',
            ],

film type has:

            'resourcecreator' => [
                'Creator1' => 'director',
                'Creator2' => 'producer',
            ],

The value of the array feeds into messages . . .

Mark

[Stéphane Aulery]

Understood.

[Mark Grimshaw]

I will look further into it.

Mark

[Mark Grimshaw]

Fix in SVN [r4320].