Re: [Widelands-public] 4 small patches are waiting
Status: Beta
Brought to you by:
sirver
From: Erik <fr...@ho...> - 2006-02-20 20:23:08
|
Florian Weber wrote: >put the globally defined operators into the classes? > Here is a patch that attempts to clean up geometry.h. It makes those operators member functions, removes the unused Point_with_bright, fixes const issues and tries to put members of the structs in a consistent order: * data members <blank line> * constructors <blank line> * other member functions Initialization is also fixed by properly using the initializer list instead of assignment operations in the body. All overlong lines are fixed and formatting is also otherwise made consistent. About this comment: // TODO adding points doesn't make sense Is it still valid? I can not remove the operator+ and operator- for points because they are used. I left the comment in but I suggest removing it. |