Re: [Widelands-public] Widelands Build 19 package for Debian - Appdata File

[Holger R. <Si...@gm...>]

+ widelands-public

> On 24.11.2016, at 22:10, Hans Joachim Desserud <wid...@de...> wrote:
> 
> 
> Hi Martin
> and thanks for packaging Widelands in Debian. :)
> 
> Happy to see that it has built successfully on most architectures
> without any additional patches this time round [1]. I've tested the
> packages a bit and the only issue I've found is that the desktop file
> points to a non-existing icon. Instead it is shown with a blank or no
> icon in menus and other places. Would be nice if you could fix this.
> 
> 
>> Some comments on the other remarks on the pull request. That's just my
>> opinion, feel perfectly free to disregard them.
> 
> Great :)
> 
>> - I don't see why you would prefer to use the embeeded fonts. The
>>  packages contain the exact same files... I understand why you
>>  package it bundled for windows and mac, but I really don't see the
>>  point on linux (that's harmless if you really want)
> 
> Found an old discussion in the bug tracker [2]. At least for now,
> I've continued to use the embedded fonts since that's what we did
> before merging the latest packaging as well. :/ I didn't re-read all
> of the bug report, but we might take a look and see whether we still
> reach the same conclusion.
> 
>>  Btw, if you could transition to packaged fonts for the remaining
>>  ones, that'd be perfect, please.
>> - 14.04 is a rather old. Are you sure you still need to maintain this
>>  version?

Our server runs 14.04 and we rely on our PPA to supply it with current binaries. I am not sure how much that has an influence on our debian release. 

> 
> This is probably my idea, as a part of the overall goal to have
> Widelands available on as many systems as possible. It is probably
> easier for most people if they wish to test the latest development
> version to install a binary package than build on their own. So as
> long as it builds fine out of the box, we might as well provide a
> pre-built alternative. Also, we are able to test and verify it builds
> with different versions of compilers and libraries. Since some
> distros may have older versions and others bleeding edge, it is nice
> to know that both options are supported and it still works on what we
> say are the minimum required versions.
> (Note that we dropped support for 12.04 when it became cumbersome due
> to old GCC plus no SDL2 packages in the default archive)
> 
>> - get-orig-source is to download the latest version of the tgz when
>>  you guys release a new version. That's for me, useless to you.
> 
> Ok, I've commented it out now.
> 
>> I hope this make does not sound to harsh, I'm just in a rush. No
>> offense intended.
> 
> No problem, I'm happy for the feedback at least.
> 
> Another thing you mentioned was placing the desktop file and manpage
> outside the debian directory. This could be done, and would probably
> annoy packagers on other distros a lot less than currently :P. I'd
> like a few pointers on how to best do this though, simply copy in the
> files in the override_dh_auto_install section of rules and leave the
> install files as is, or something different? I think my main problem
> is that I don't have a clear view of what is present when the
> .install files are used or how to easily add new ones.
> 
> 
> In related news, the build19 packages has been synced automatically
> to the current development version of Ubuntu (Zesty) [3]. Though it
> hasn't made its way from -proposed, which is their staging ground, to
> the offical archive. From what I understand, this seems to be due to
> glew transitioning to 2.0 [4], and they want to make sure everything
> still works. I believe once that is completed, Widelands will enter
> the official archives as well. If it drags out, I'll investigate more.
> 
> 
> [1] https://buildd.debian.org/status/package.php?p=widelands
> [2] https://bugs.launchpad.net/widelands/+bug/973714
> [3] https://launchpad.net/ubuntu/+source/widelands
> [4] https://launchpad.net/ubuntu/+source/glew
> 
> ---
> mvh / best regards
> Hans Joachim Desserud
> http://desserud.org