Re: [Widelands-public] Barbarian Trainingscamp and no warmill

[Teppo M. <tep...@ce...>]

On Thu, May 09, 2013 at 11:44:52AM +0200, Holger Rapp wrote:

>>> - this loop should only check what is really thought in the site - I think.
>> I did not understand. Could you please re-word?

>the look should only check over the stuff that is really taught in this 
>training site - i.e. I believe that your code does not do the correct thing 
>for a trainingsite that only trains attack.

No, this does not happen. Unless there is a bug.

>It should work with python 2.7 which is the stable version for a few years. Could you retry with that?

I have now tried. The tool is happy, at least when I run it.

>> Are there config files for a text editor like Emacs or so, that would be able
>> to pretty-print the code directly into project recommended setting? That
>> would be helpful.
>Yes - but there aren't. I am inclined to change the coding style to the 
>default google style which is supported via clang-format or at least relax 
>the style checker so that clang format code is always accepted and valid. 
>Help with that would be appreciated :)
>http://clang.llvm.org/docs/ClangFormat.html

If you or somebody decides that "google-clang.style" shall be right, then 
the straightforward way would be to put a clang style file to trunk, declare 
the old python tool obsolete and move it to the museum part? Why should there 
be two bosses?

>no, there should be no stoppers in saving this to a file. there is very 
>likely already a package for trainingsites and you just need to bump it's 
>version number and write save and load code and make sure that old games 
>without your code still load properly.

I intended to say that putting the state to save game does not really pay in 
my opinion. Would you like the state to be in a savegame file?

>Let me know when I should have another view over your code.

Now, for example.

Regards,


	Teppo