Re: [Widelands-public] FindSDL.cmake necessary?

[Jari H. <jar...@ik...>]

Hi!

2010/3/29 Holger Rapp <Hol...@gm...>:
> Hi,
>>
>> 2010/3/28 Holger Rapp <Hol...@gm...>:
>>> Hi,
>>>>
>>>> As I checked with timowi, FindSDL.cmake script is already in CMake
>>>> 2.6.0 and also in CMake 2.8.0 and 2.8.1. However we are using a
>>>> custom one in cmake/Modules/FindSDL.cmake. Build also works for me
>>>> when deleting this file... can I remove this file or is this
>>>> necessary for maybe OSX or Win32/Mingw?
>>> This script was added on the WiHack because compilation failed on Mac
>>> OS X. We added a copy & pasted script that also searches in /opt/local
>>> and /sw/ for the SDL libs.
>>>
>>
>> MSVC build uses CMAKE_INCLUDE_PATH and CMAKE_LIBRARY_PATH variables to
>> show cmake find system place to search 3rd party libs. Also
>> CMAKE_PREFIX_PATH may be good option for Mac OSX to include macports
>> or fink libs.
> Are these Environment variables? Our own FindSDL.cmake automatically finds cmake, that's the way it should be. Changing this so that environment variables are needed is imho a regression.

Yes, these are linked to environment variables. I manipulate them for
MSCV build as it was intenteded to be used with specific 3rdparty
bundle directory. But for other platforms things are of course
different.

Besides there seems to some other changes than just path changes, so
better leave that working peace of cmake code alone.

Cheers,
Jari