Re: [Widelands-public] Some notes on attack system

[Raul F. <rau...@gm...>]

En Wed, 30 Dec 2009 15:37:11 +0100
Peter Schwanemann <Pe...@sc...> escribió:

> Hi Raul,
> 
> while testing the scenario map I commited, I noticed some points in
> current attack system:
Good to see that there are someone testing things :D

> * Currently the attack dialog is shown for *every* point of enemy
> territory, but should only be shown for enemy militarysites
Yes, I do that intentionally to test the dialog and retreat 'events' at startup. The alternative was to play a whole game until I reach the enemy ... slowing down a lot development process.
I will correct this on next commits

> * the scrollbar that allows to set how many soldiers attack is not
> updated. If more soldiers become available and any button is pressed,
> the menu updates the buttons, but not the maximum amount you can set
> with the scrollbar.
I know that, but first I need to send another patch allowing to adjust minimum and maximum values on slidebar. I can send it next days. Next commits will patch this.

> * And last but not least the thing with "not usable UI should be
> invisible" so in this case the "injured run home" bar
Of course, by now only is visible to allow easily debug the retreat_change event. It will be hidden on next commits.

> Hope I was able to give some constructive criticism :-)

You have done it, many thanks!
;-)

There is also another 'issue' with soldiers, when a soldier is at enemy military site flag's and kill last defender soldier, he retreats if his HP go below the specified value. The correct action should be enter on building, because there is no other defender! This is at my ToFix list ;)

Tell me if you found any bugs or issues.

-- 
Raul Ferriz <rau...@gm...>