[Widelands-public] [ widelands-Bugs-2834688 ] regression in revision 3147: Cmd_Call_Economy_Balance::Read

[SourceForge.net <no...@so...>]

Bugs item #2834688, was opened at 2009-08-10 03:44
Message generated for change (Tracker Item Submitted) made by sigra
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=427221&aid=2834688&group_id=40163

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: game engine (game logic)
Group: None
Status: Open
Resolution: None
Priority: 9
Private: No
Submitted By: Erik Sigra (sigra)
Assigned to: Erik Sigra (sigra)
Summary: regression in revision 3147: Cmd_Call_Economy_Balance::Read

Initial Comment:
Cmd_Call_Economy_Balance::Read has this code since a long time:
				Economy * const economy =
					fr.Unsigned8 () ?
					player->get_economy_by_number(fr.Unsigned16()) : 0;


So if the first byte read is 0, economy will be 0. But in revision 3147, the following line was added after:
m_flag = economy->get_arbitrary_flag();

But that will dereference a null pointer if the first byte read in the expression above is 0 (and cause a segmentation fault).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=427221&aid=2834688&group_id=40163