|
From: Miro J. <me...@me...> - 2003-08-23 18:01:45
|
1. Debugging trace macros
1 TRACE
1 TRACEFLOW
Proposed action: rename to WHISPER_TRACE and WHISPER_TRACEFLOW to
avoid conflicts in the global "namespace" in non-debug targets (in
debug targets, these are templates)
2. Assertion macros
12 ASSERT
3 ASSERT_IF
2 REQUIRE (exits on failure, used in bootstrapping)
3 VERIFY (throws in release builds, asserts in debug builds)
2 SAFE_ASSERT (interrupt-safe version)
2 COMPILE_CHECK (compile-time assert)
Proposed action: renamed to WHISPER_..., same reason
3. Design by contract
2 CALL_INVARIANT (direct call to invariant function)
2 CHECK_INVARIANT (stack-based invariant checker)
3 POSTCONDITION
3 PRECONDITION
3 OBSERVE (helper for postcondition checking)
Proposed action: renamed to WHISPER_..., same reason
4. DebugStr-related
2 DEBUGSTR
1 DEBUGSTR_IF (conditional version)
1 SAFE_DEBUGSTR (interrupt-safe version)
Proposed action: renamed to WHISPER_..., same reason
5. Macros internal to the implementation
1 PACKET_MAX_DATA_LENGTH
Only used in obsolete code. Remove altogether
1 _CC
Not a macro, but a struct used in implementation of COMPILE_CHECK;
_CC is reserved, so this needs to be renamed.
6. Configuration of Whisper
8 ASSERTS_THROW
If true, ASSERT and friends throw an exception. Rename to
WHISPER_CONFIG_ASSERTS_THROW
3 ENABLE_EXTRA_WARNINGS
If true, extra warnings are turning on in MCVS. Same should be done
for CW, and the macro should be renamed to
WHISPER_CONFIG_EXTRA_WARNINGS
27 _DEBUG
This should be eliminated in favor for Andreas' proposed WHISPER_BUILD_DEBUG
1 __STL_DEBUG
This is only used to sync with vendor STL, so it's OK.
6 NDEBUG
This is only used to sync with the C library, so it's OK.
--
<http://web.meeroh.org/> | KB1FMP
A: Because it reverses the logical flow of conversation.
Q: Why is top posting frowned upon? |