Menu

#430 Full screen board import

v0.11
closed
nobody
None
2017-03-26
2015-12-08
Anonymous
No

Originally created by: mquandalle

Work in progress, see https://github.com/wekan/wekan/issues/113#issuecomment-162945488 for rationale.

Review on Reviewable

Discussion

  • Anonymous

    Anonymous - 2015-12-17

    Originally posted by: mquandalle

    @xavierpriour, I plan to change the import flow to make it linear:

    step 1: chose the import format
    step 2: upload the data
    step 3: member mapping
    then loading bar, or spinner

    I’ve just realized that this changes the flow currently implemented when you go back and forth between step 2 and 3, but I think this is a pretty reasonable model.

    I imagine the UI should have a horizontal component showing the process progress. Clicking on a previous step should bring the user back to it. On the implementation side, all the import data would be saved under the import root component and not in the individual step components, which is a easier model to reason about. I imagine in the future, third-parties importers will be able to customize the steps, and add more if needed.

    I’ve also been blindly refactoring the client-side import code, but I’m not sure if I do things correctly :-/

    Also, as the actual import “business logic” is located in the models/ directory, so it is distributed in both the client and the server, which means that the importTrelloBoard method runs on both the environments. Is that on purpose? It seems unnecessary heavy to me to run the latency compensation method on the client, especially since we are waiting for server completion with a spinner anyway.

     
  • Anonymous

    Anonymous - 2015-12-18

    Originally posted by: xavierpriour

    @mquandalle, a multi-step wizard definitely makes sense for such a process.

    Import was latency-compensated because why not? I could see this useful in a bad network/offline scenario, so not sure it's really worth removing it.

     
  • Anonymous

    Anonymous - 2015-12-18

    Originally posted by: mquandalle

    I need to look closer at the client side method performance for latency compensation, but I was under the impression that it freezes the client for a few seconds if you import large boards. Otherwise, yes, why not.

     
  • Anonymous

    Anonymous - 2016-01-30

    Originally posted by: mquandalle

    @xavierpriour this should be completed as a basic UI change from popup to full screen, it also fixes [#504]. Could you take a quick look?

     
  • Anonymous

    Anonymous - 2016-02-01

    Ticket changed by: mquandalle

    • status: open --> closed
     
  • Anonymous

    Anonymous - 2017-03-26

    Originally posted by: savolai

    Hi. I just created a sandstorm grain for Wekan but can't find the import functionality anywhere. Ideas? Thanks. ^_^

     
  • Anonymous

    Anonymous - 2017-03-26

    Originally posted by: xet7

    @savolai

    It's not yet on Sandstorm, see [#799]

     
  • Anonymous

    Anonymous - 2017-03-26

    Originally posted by: savolai

    Thanks.

     

Log in to post a comment.