[Webware-devel] Re: support for the psp-handler in mod_webkit and ModPythonAdapter

[Stuart D. <st...@as...>]

Stuart Donaldson wrote:

> I am encountering numerous problems trying to use the psp-handler with 
> mod_webkit, and some of the more recent code in Webware.
>
> The PSP handler in mod_webkit sets WK_ABSOLUTE=1 to indicate that the 
> request is not relative to one of the webware directories.
>
> HTTPRequest urlPath() checks this, and returns the fsPath() or file 
> system path under this circumstance.  That appears to be the only case 
> where the urlPath() returned is a file system path rather than web 
> server url component.
>
> The serverSideInfoForRequestNewAlgorithm does not check for the 
> absolute condition, and tries to process the filesystem path as a url, 
> passing it off to findContext() et al...  The old algorithm did check 
> for this by the way.
>
> Is there ever a circumstance where urlPath() should really be 
> returning a filesystem path rather than a URL component?  It seems 
> like code which wants to check for absolute paths from the psp-handler 
> should probably look specifically at wether or not the request is an 
> absolute request, and then use fsPath() instead.  One of the with 
> urlPath returning a file system path is that it is often combined with 
> other components of a URL to generate new URL's.
>
> It appears that this general approach of using the psp-handler is 
> really broken in the New functions, and I just wanted to check to see 
> if the psp-handler approach is something we want to continue to 
> support, or if it is being phased out.  I'm kind of surprised it 
> hasn't come up much before. 
> Perhaps the problem is that I'm also working with code in 
> NewThreadedAppServer which may not be getting the broad testing we 
> would like.

Actually what I meant to say:  Perhaps the problem is that some of the 
code indicated by "New" isn't getting used that much.  The 
NewThreadedAppServer and serverSideInfoForRequestNewalgorithm which is 
only enabled when ExtraPathInfo is also enabled.

-Stuart-