Re: [Webmacro-devel] Bug in caching of { } declarations (Was Re: Bug in repeating invocations of #eval, )

[Alex F. <al...@fi...>]

Hi Tim

On 15 April 2012 18:11, Tim Pizey <ti...@pa...> wrote:

> Hi Alex,
>
> On 11 April 2012 00:05, Alex Fiennes  wrote:
> > All,
> >
> > I've been doing some more thinking about the problem defined below and
> I've
> > got some updates to the situation...
>

<snip>


> > If anyone can see any flaws in the above then let me know - otherwise I
> will
> > commit the updates and move forwards...
> >
>
> I cannot see a flaw, but that is not saying much.
>
> Are you going to commit a failing test first and then a fix for that?
>

I haven't written a test in the webmacro framework, but I will do so.  I
have already written the fix and tested it manually so that is currently in
use by me.

As it happens, I have just thought of another reason why the fix is useful
- having the Map that is generated by the parser re-used opens up threading
issues because there is no guarantee that you will not get the same Map
being used by multiple threads rendering the same Template in parallel
which will open up nasty crashes due to parallel operations on HashMaps.
 I'm not going to be able to write a test for that one though...


> I do not currently use any of the fancy features of WM,
> only its most basic functionality, so am not a central user.
>
> Which repository are you committing to? (or are you still using CVS?)
>

I am still using my github clone that we had the brief thread about
earlier.  I will ensure that there is a branch at the point when I started
doing work on things, I don't know whether or not people will want all
changes folded back into the "official" version as I will be playing around
with different things which might not be guaranteed to be backwards
compatible.  However, if I find things that seem to be actually broken in
the code that isn't mine then I'll post something to webmacro-devel and
back port things as time permits (or point other people at the appropriate
commits on my branch so that they can do so)

Alex


> cheers
> Tim
>
>
>
>
>
>
> --
> Tim Pizey
> http://pizey.net/~timp
>



-- 
Alex Fiennes
email: al...@fi...
mobile:  +44 (0)7813 832662
office: +44 (0)1875 823 310