webadmin-list

[webmin-l] bugfixes: xmlrpc in webmin

[<jer...@li...>]

Hi,

I'm actually using xmlrpc function from devel snapshot.

I've got two suggestions on "xmlrpc.cgi" code.

1) Specify encoding which helps xml parser. I've got some annoying=20
exceptions with my python xmlrpc client if I don't specify it.

2) Why choose "::" as separators ? I change it by "." which is, I think,=20
more "XMLRPC RFC compliant".

Here is my diff file.

54c55
< my $xmlrv =3D "<?xml version=3D\"1.0\"?>\n";
---
 > my $xmlrv =3D "<?xml version=3D\"1.0\" encoding=3D\"ISO-8859-1\"?>\n";
59,60c60,61
<       my ($mod, $func) =3D $mn->[1]->[2] =3D~ /::/ ?
<                       split(/::/, $mn->[1]->[2]) : (undef, $mn->[1]->[2=
]);
---
 >       my ($mod, $func) =3D $mn->[1]->[2] =3D~ /\./ ?
 >                       split(/\./, $mn->[1]->[2]) : (undef,=20
$mn->[1]->[2]);

Hope this could help you.

Cordially,
Wax J=E9r=F4me
-----------------------------------
http://www.lo2k.net

Re: [webmin-l] bugfixes: xmlrpc in webmin

[Jamie C. <jca...@we...>]

On 16/Aug/2006 06:48 =?ISO-8859-1?Q?J=E9r=F4me_Wax?= wrote ..
> Hi,
> 
> I'm actually using xmlrpc function from devel snapshot.
> 
> I've got two suggestions on "xmlrpc.cgi" code.
> 
> 1) Specify encoding which helps xml parser. I've got some annoying 
> exceptions with my python xmlrpc client if I don't specify it.
> 
> 2) Why choose "::" as separators ? I change it by "." which is, I think,
> more "XMLRPC RFC compliant".
> 
> Here is my diff file.
> 
> 54c55
> < my $xmlrv = "<?xml version=\"1.0\"?>\n";
> ---
>  > my $xmlrv = "<?xml version=\"1.0\" encoding=\"ISO-8859-1\"?>\n";
> 59,60c60,61
> <       my ($mod, $func) = $mn->[1]->[2] =~ /::/ ?
> <                       split(/::/, $mn->[1]->[2]) : (undef, $mn->[1]->[2]);
> ---
>  >       my ($mod, $func) = $mn->[1]->[2] =~ /\./ ?
>  >                       split(/\./, $mn->[1]->[2]) : (undef, 
> $mn->[1]->[2]);
> 
> Hope this could help you.

Thanks for the suggestions .. I will add that encoding in the next release of
Webmin, and accept both . and :: as module-function separators.

 - Jamie