Joe Cooper wrote:
> Hi Jamie,
>
> In the Filesystems module, I find the "Files inherit parent GID? Yes
> No" option confusing. Shouldn't the choices have their meaning reversed
> to behave the way they do?
>
> I.e. when I see the question, I think "Files inherit the GID of the
> parent _directory_?", not "Files inherit the GID of of the parent
> _executing process_ or the _user creating the file_?" But it behaves as
> though the question is the latter rather than the former by adding grpid
> to the mount options when set to "No" and taking it away when set to "Yes".
>
> Since it defaults to a negative in mount, shouldn't this option in
> Webmin also default to "No"? I think the simplest thing to do is
> reverse the Yes/No meanings.
>
> I would also suggest a slight wording change to make it clear what the
> "parent" is in this case...I never would have guessed "parent process or
> user" was intended. I would also prefer to see the default match the
> default of the mount command--so it defaults to a negative, just as the
> mount option defaults to a negative.
>
> Just an opinion of course. If everyone else sees this and reads the
> right meaning into it, I'll just document it and move on.
You're right, that option is rather confusing :) I'll change it to read
'Files inherit GID of parent directory?' and swap the Yes and No.
- Jamie
|
