From: Mátyás C. <cs...@gm...> - 2019-04-06 18:24:27
|
Hello! The php packages from https://packages.sury.org/ are named like "phpx.y-fpm" The files contained in the package are, for example: root@virtualmin:~# dpkg -L php7.3-fpm /. /etc /etc/apache2 /etc/apache2/conf-available /etc/apache2/conf-available/php7.3-fpm.conf /etc/init /etc/init/php7.3-fpm.conf /etc/init.d /etc/init.d/php7.3-fpm /etc/logrotate.d /etc/logrotate.d/php7.3-fpm /etc/php /etc/php/7.3 /etc/php/7.3/fpm /etc/php/7.3/fpm/conf.d /etc/php/7.3/fpm/php-fpm.conf /etc/php/7.3/fpm/pool.d /etc/php/7.3/fpm/pool.d/www.conf /lib /lib/systemd /lib/systemd/system /lib/systemd/system/php7.3-fpm.service /usr /usr/lib /usr/lib/php /usr/lib/php/7.3 /usr/lib/php/7.3/sapi /usr/lib/php/7.3/sapi/fpm /usr/lib/php/php7.3-fpm-reopenlogs /usr/lib/tmpfiles.d /usr/lib/tmpfiles.d/php7.3-fpm.conf /usr/sbin /usr/sbin/php-fpm7.3 /usr/share /usr/share/bug /usr/share/bug/php7.3-fpm /usr/share/bug/php7.3-fpm/control /usr/share/bug/php7.3-fpm/script /usr/share/doc /usr/share/lintian /usr/share/lintian/overrides /usr/share/lintian/overrides/php7.3-fpm /usr/share/man /usr/share/man/man8 /usr/share/man/man8/php-fpm7.3.8.gz /usr/share/php /usr/share/php/7.3 /usr/share/php/7.3/fpm /usr/share/php/7.3/fpm/status.html /usr/share/doc/php7.3-fpm This layout is not picked up by php-lib.pl, because the dot inside the package names/paths is deliberately being masked/removed inside multiple parts of php-lib.pl. Removing these from around lines 947, 1316, 1711 1732,1766, 1780 - without knowing exactly what am I breaking - the packages get picked accepted as a valid FPM version, the pool configuration files are created properly, and everything works as expected. My questions are: 1; Why is the version dot removed in the first place? 2; I know RPM-based distributions are preferred for running Virtualmin, but would there be a way to make support for sury.org PHP packages without breaking anything? 3; Is there a way to modify the pool configration generated by php-lib.pm? Details regarding this question: - In php-lib.pl I see "web_phpchildren" would be substituted, but I don't know where to set that value inside virtualmin - Inside "Server templates > PHP configuraton" I see templates, but that is not related to the pool configuration generated - Would It be possible to have templating for the whole pool file generated? Thanks, M |
From: Jamie C. <jca...@we...> - 2019-04-08 04:50:29
|
It looks like the core problem is that the binary name /usr/sbin/php-fpm7.3 isn't being detected, as that's not a filename format Virtualmin looks for. We'll fix this in the next release. On 06/Apr/2019 11:24 Mátyás Csere <cs...@gm...> wrote .. Hello! The php packages from https://packages.sury.org/ are named like "phpx.y-fpm" The files contained in the package are, for example: root@virtualmin:~# dpkg -L php7.3-fpm /. /etc /etc/apache2 /etc/apache2/conf-available /etc/apache2/conf-available/php7.3-fpm.conf /etc/init /etc/init/php7.3-fpm.conf /etc/init.d /etc/init.d/php7.3-fpm /etc/logrotate.d /etc/logrotate.d/php7.3-fpm /etc/php /etc/php/7.3 /etc/php/7.3/fpm /etc/php/7.3/fpm/conf.d /etc/php/7.3/fpm/php-fpm.conf /etc/php/7.3/fpm/pool.d /etc/php/7.3/fpm/pool.d/www.conf /lib /lib/systemd /lib/systemd/system /lib/systemd/system/php7.3-fpm.service /usr /usr/lib /usr/lib/php /usr/lib/php/7.3 /usr/lib/php/7.3/sapi /usr/lib/php/7.3/sapi/fpm /usr/lib/php/php7.3-fpm-reopenlogs /usr/lib/tmpfiles.d /usr/lib/tmpfiles.d/php7.3-fpm.conf /usr/sbin /usr/sbin/php-fpm7.3 /usr/share /usr/share/bug /usr/share/bug/php7.3-fpm /usr/share/bug/php7.3-fpm/control /usr/share/bug/php7.3-fpm/script /usr/share/doc /usr/share/lintian /usr/share/lintian/overrides /usr/share/lintian/overrides/php7.3-fpm /usr/share/man /usr/share/man/man8 /usr/share/man/man8/php-fpm7.3.8.gz /usr/share/php /usr/share/php/7.3 /usr/share/php/7.3/fpm /usr/share/php/7.3/fpm/status.html /usr/share/doc/php7.3-fpm This layout is not picked up by php-lib.pl, because the dot inside the package names/paths is deliberately being masked/removed inside multiple parts of php-lib.pl. Removing these from around lines 947, 1316, 1711 1732,1766, 1780 - without knowing exactly what am I breaking - the packages get picked accepted as a valid FPM version, the pool configuration files are created properly, and everything works as expected. My questions are: 1; Why is the version dot removed in the first place? 2; I know RPM-based distributions are preferred for running Virtualmin, but would there be a way to make support for sury.org PHP packages without breaking anything? 3 ; Is there a way to modify the pool configration generated by php-lib.pm? Details regarding this question: - In php-lib.pl I see "web_phpchildren" would be substituted, but I don't know where to set that value inside virtualmin - Inside "Server templates > PHP configuraton" I see templates, but that is not related to the pool configuration generated - Would It be possible to have templating for the whole pool file generated? Thanks, M |