webadmin-devel

[webmin-devel] Some changes for better themes.

[Eldy <el...@us...>]

Is it possible to replace in all webmin code the following strings
<input type=button
by
<input class=button type=button

and also
<input type=submit
by
<input class=button type=submit

Such a change should be safe and can be done by a recursive replace in all webmin .pl files.
It will allows theme developpers to add a more personalised look in theme (by adding on
buttons a different css style, for example a 3D style from a picture, using the "button" class).
This is for the moment not possible because if doing this by using the "input" class,
all other input fields (like input=text) are also affected.

This is to have themes that looks nicer than it is possible to do now.


-- 

Laurent Destailleur.
---------------------------------------------------------------
EMail: el...@us...
AWStats : http://awstats.sourceforge.net
Dolibarr : http//dolibarr.com
CVSChangeLogBuilder : http://cvschangelogb.sourceforge.net
AWBot : http://awbot.sourceforge.net

{Spam?} Re: [webmin-devel] Some changes for better themes.

[<ra...@si...>]

  I would argue that all input types have a class that is equivilent to
the type.  Or better yet, have the input be part of a UI function so that
it can even be replaced.  i.e.:

   draw_input($type, $name, $value, $size, ...);

This is more flexible, but there would be a lot of replacements that will
need to be done.

	---- Randy

On Wed, 4 May 2005, Eldy wrote:

> Is it possible to replace in all webmin code the following strings
> <input type=button
> by
> <input class=button type=button
>
> and also
> <input type=submit
> by
> <input class=button type=submit
>
> Such a change should be safe and can be done by a recursive replace in all webmin .pl files.
> It will allows theme developpers to add a more personalised look in theme (by adding on
> buttons a different css style, for example a 3D style from a picture, using the "button" class).
> This is for the moment not possible because if doing this by using the "input" class,
> all other input fields (like input=text) are also affected.
>
> This is to have themes that looks nicer than it is possible to do now.
>
>
> --
>
> Laurent Destailleur.
> ---------------------------------------------------------------
> EMail: el...@us...
> AWStats : http://awstats.sourceforge.net
> Dolibarr : http//dolibarr.com
> CVSChangeLogBuilder : http://cvschangelogb.sourceforge.net
> AWBot : http://awbot.sourceforge.net
>
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by: NEC IT Guy Games.
> Get your fingers limbered up and give it your best shot. 4 great events, 4
> opportunities to win big! Highest score wins.NEC IT Guy Games. Play to
> win an NEC 61 plasma display. Visit http://www.necitguy.com/?r=20
> -
> Forwarded by the Webmin development list at web...@we...
> To remove yourself from this list, go to
> http://lists.sourceforge.net/lists/listinfo/webadmin-devel
>

Re: [webmin-devel] Some changes for better themes.

[Jamie C. <jca...@we...>]

On Wed, 2005-05-04 at 13:38, Eldy wrote:
> Is it possible to replace in all webmin code the following strings
> <input type=button
> by
> <input class=button type=button
> 
> and also
> <input type=submit
> by
> <input class=button type=submit
> 
> Such a change should be safe and can be done by a recursive replace in all webmin .pl files.
> It will allows theme developpers to add a more personalised look in theme (by adding on
> buttons a different css style, for example a 3D style from a picture, using the "button" class).
> This is for the moment not possible because if doing this by using the "input" class,
> all other input fields (like input=text) are also affected.
> 
> This is to have themes that looks nicer than it is possible to do now.

I am actually in the process of replacing all the code that simply
prints out HTML for form inputs with calls to a function, which can be
overridden by a theme. So code like :

print "<input type=submit name=ok value='Click Me'>\n";

is being replaced with :

print &ui_submit("Click Me", "ok"),"\n";

Your theme will then be able to define a function call theme_ui_submit
in it's theme.pl file, which will override ui_submit and can return
whatever HTML you like for the button.

Not all modules use these new functions yet, but some (like Logrotate
and IPFilter) do ..

 - Jamie