webadmin-devel

Problem with fileupload

[Gehrigal - W. <we...@ge...>]

Hi all,

at the moment i am working on a new module for webmin.
In this module the user should be able to upload files.
But there is a bug in my perlscripte, and so the uploaded file will be
allways 0 byte.

.....
my $q = new CGI;

my $file        = $q->param("file") || &error( "No File received!");
my $file_name   = $q->param("file_name") || & error ( "There was no
Filename!");
my $fh          = $q->upload("file");
my $buffer      = "";


my $full_filename="$skin_dir"."/"."$file_name";

open(OUTPUT, ">$full_filename");
while (read( $fh, $buffer, 512000) ){ print OUTPUT $buffer;}
close (OUTPUT);

......


Any ideas?

thx

Alex

Re:Problem with fileupload

[Gehrigal - W. <we...@ge...>]

hi Jamie

thanks! - But when i try yourt solution i get allways this output message:
"Missing Content-Disposition header"

>I'm not too familiar with the CGI module, but using webmin's API you could
>write :

>&ReadParseMime();
>my $full_filename="$skin_dir"."/".$in{'file_name'};
>open(OUTPUT, ">$full_filename");
>print OUTPUT $in{'file'};
>close(OUTPUT);

Re: Problem with fileupload

[Jamie C. <jca...@we...>]

Does the form that submits to this CGI look like :

<form action=whatever.cgi method=post enctype=multipart/form-data>

  - Jamie

Gehrigal - Webminprojects wrote:
> hi Jamie
> 
> thanks! - But when i try yourt solution i get allways this output message:
> "Missing Content-Disposition header"
> 
> 
>>I'm not too familiar with the CGI module, but using webmin's API you could
>>write :
> 
> 
>>&ReadParseMime();
>>my $full_filename="$skin_dir"."/".$in{'file_name'};
>>open(OUTPUT, ">$full_filename");
>>print OUTPUT $in{'file'};
>>close(OUTPUT);

Re: Problem with fileupload

[Gehrigal - W. <we...@ge...>]

hi

>> my $q = new CGI;
>>
>> my $file        = $q->param("file") || &error( "No File received!");

>I know it shouldn't matter, but it seems to be a bad idea to name a
>variable and a file handle the same...IMHO.  Could cause confusion.

There is no problem to do this... the variablename and parametername are to
different things.

>I would do an open as binary here, otherwise the output will always be
>ascii (I think...would have to go back and do some reading on that).

I think i have to use the binmode only on Windowsserver. On Unixservers this
cgi function will not work.

bye


Alex

Re: Problem with fileupload

[Jamie C. <jca...@we...>]

Gehrigal - Webminprojects wrote:
> Hi all,
> 
> at the moment i am working on a new module for webmin.
> In this module the user should be able to upload files.
> But there is a bug in my perlscripte, and so the uploaded file will be
> allways 0 byte.
> 
> .....
> my $q = new CGI;
> 
> my $file        = $q->param("file") || &error( "No File received!");
> my $file_name   = $q->param("file_name") || & error ( "There was no
> Filename!");
> my $fh          = $q->upload("file");
> my $buffer      = "";
> 
> 
> my $full_filename="$skin_dir"."/"."$file_name";
> 
> open(OUTPUT, ">$full_filename");
> while (read( $fh, $buffer, 512000) ){ print OUTPUT $buffer;}
> close (OUTPUT);

I'm not too familiar with the CGI module, but using webmin's API you could
write :

&ReadParseMime();
my $full_filename="$skin_dir"."/".$in{'file_name'};
open(OUTPUT, ">$full_filename");
print OUTPUT $in{'file'};
close(OUTPUT);

  - Jamie

Re: Problem with fileupload

[Tony S. <tsh...@ma...>]

> my $q = new CGI;
>
> my $file        = $q->param("file") || &error( "No File received!");

I know it shouldn't matter, but it seems to be a bad idea to name a
variable and a file handle the same...IMHO.  Could cause confusion.


I would do an open as binary here, otherwise the output will always be
ascii (I think...would have to go back and do some reading on that).

> open(OUTPUT, ">$full_filename");
> while (read( $fh, $buffer, 512000) ){ print OUTPUT $buffer;}
> close (OUTPUT);
>