Thanks for the patch - I will incorporate it into the upcoming 1.120 release
of Webmin. Since I don't run Samba 3 with LDAP myself, I'll just have to trust
you that it works :-)
One question though - what if the 'Domain SID for Samba3' module configuration
option is not set?
- Jamie
Isaac Finnegan <is...@co...> wrote ..
> Here's the patch for the LDAP Users/Groups module that better supports
> Samba3
>
> Changes:
> -Added other_class field in module config that allows you to specify
> other objectClasses to add to the newly created user (not necessary for
> samba3, but I needed it ;) )
> -Changed the samba attributes code to add samba3 attributes when
> samba_class = sambaSamAccount
> Didn't just use the schema check since it's possible to have both the
> samba and samba3 schema's loaded while transitioning to the new schema.
> If the samba_class is sambaAccount everything works as before.
> -Added "Domain SID for Samba3" property, since this is needed to
> calculate the sambaSID and sambaPrimaryGroupSID for users
>
> To use with samba3:
> in the module config, change the "LDAP object class for Samba users" to
> sambaSamAccount
>
> Add the following to the LDAP properties for new Samba users:
> At least:
> sambaSID
> sambaAcctFlags
> sambaNTPassword
> sambaLMPassword
> sambaPrimaryGroupSID
>
> You can add the other samba3 attributes, and you will need to also add
> them to the "Extra LDAP properties to allow editing" area
>
> How does this look? It's a patch against the 1.119 dev release
>
> Notes:
> I really love webmin and would love to contribute more (to this module
> in particular.) Here's what I want to do:
> -Enhance help area, it's hard to get started with this module unless
> you really know what you're doing.
> -make groups use posixGroups and groupOfNames so it can be used to
> manage LDAP groups that can be used by other apps or the security
> settings in the LDAP server.
|
